ce1bbdb Improve description under registration address — radicle-explorer

Radicle web interface

Improve description under registration address

Alexis Sellier committed 4 years ago

commit ce1bbdb61707ffeb5c91895b4b9bf6b32c60195a
parent 49f9116b1083847edb35f302bc5aa95f0b06240a

4 files changed +29 -7

modified src/Form.svelte

@@ -12,6 +12,7 @@

 <script lang="ts">
   import { createEventDispatcher } from 'svelte';
   import marked from 'marked';
   import { capitalize, isUrl, isAddress } from '@app/utils';
   import Address from '@app/Address.svelte';
   import type { Config } from '@app/config';

@@ -60,6 +61,10 @@

     padding-left: 1rem;
     max-width: 32rem;
   }
   .description :global(p) {
     padding: 0;
     margin: 0;
   }
   input.field {
     border-radius: 1rem;

@@ -122,7 +127,7 @@

         </span>
       {/if}
       <div class="description text-small faded">
         {field.description}
         {@html marked(field.description)}
       </div>
     </div>
   {/each}

modified src/base/registrations/View.svelte

@@ -10,7 +10,7 @@

   import type { Field } from '@app/Form.svelte';
   import { assert } from '@app/error';
   import Error from '@app/Error.svelte';
   import { isAddressEqual } from '@app/utils';
   import { isAddressEqual, isReverseRecordSet } from '@app/utils';
   import { getRegistration } from './registrar';
   import type { EnsRecord } from './resolver';

@@ -33,6 +33,8 @@

   export let subdomain: string;
   export let config: Config;
   subdomain = subdomain.toLowerCase();
   let state: State = { status: Status.Loading };
   let editable = false;
   let fields: Field[] = [];

@@ -41,16 +43,25 @@

   onMount(() => {
     getRegistration(name, config)
       .then(r => {
       .then(async r => {
         if (r) {
           let reverseRecord = false;
           if (r.address) {
             reverseRecord = await isReverseRecordSet(r.address, name, config);
           }
           fields = [
             { name: "owner", placeholder: "",
               description: "The owner and controller of this name.",
               value: r.owner, resolve: true, editable: false },
             { name: "address", placeholder: "Ethereum address, eg. 0x4a9cf21...bc91",
               description: "The address this name resolves to. "
               + "For this name to be correctly associated with the address, "
               + "a reverse entry should also be set on the address.",
               description: "The address this name resolves to. " + (
                 reverseRecord
                   ? `The reverse record for this address is set to **${name}**`
                   : "The reverse record for this address is **not set**. "
                   + "For this name to be correctly associated with the address, "
                   + "a reverse record should be set."
               ),
               value: r.address, editable: true },
             { name: "url", label: "URL", placeholder: "https://acme.org",
               description: "A homepage or other URL associated with this name.",

modified src/ens/SetName.svelte

@@ -123,7 +123,8 @@

 {:else}
   <Modal floating>
     <div slot="title">
       🖊️
       <div>🖊️</div>
       <span>Reverse record</span>
     </div>
     <div slot="subtitle">

modified src/utils.ts

@@ -31,6 +31,11 @@ export interface SafeTransaction {

     operation: number;
 }
 export async function isReverseRecordSet(address: string, domain: string, config: Config): Promise<boolean> {
   const name = await config.provider.lookupAddress(address);
   return name === domain;
 }
 export function isAddressEqual(left: string, right: string): boolean {
   return left.toLowerCase() === right.toLowerCase();
 }