Radish alpha
r
radicle-explorer
Radicle web interface
Radicle
Git (anonymous pull)
Log in to clone via SSH
Commits ›
Add a UI test flow for issues
Sebastian Martinez committed 2 years ago
commit 91f5abafd3cba78689158d348c13da36ce45ca4b
parent 8e7e94c896343dfe15eaafcc7720e0bf985fa941
6 files changed +97 -37
modified src/views/projects/Cob/AssigneeInput.svelte
@@ -101,7 +101,7 @@
        on:remove={removeAssignee}

        removeable={editInProgress || action === "create"}

        {key}>
- 
        <div class="chip-content">
+ 
        <div aria-label="chip" class="chip-content">

          <Avatar inline nodeId={assignee} />

          <span>{formatNodeId(assignee)}</span>

        </div>
modified src/views/projects/Cob/CobStateButton.svelte
@@ -64,7 +64,7 @@
  </Button>

  <Floating>

    <svelte:fragment slot="toggle">
- 
      <button class="toggle">
+ 
      <button aria-label="stateToggle" class="toggle">

        <Icon name="chevron-down" />

      </button>

    </svelte:fragment>
modified src/views/projects/Cob/TagInput.svelte
@@ -96,7 +96,7 @@
        on:remove={removeTag}

        removeable={editInProgress || action === "create"}

        {key}>
- 
        <div class="tag">{tag}</div>
+ 
        <div aria-label="chip" class="tag">{tag}</div>

      </Chip>

    {:else}

      <div class="txt-missing">No tags</div>
deleted tests/e2e/httpd.spec.ts
@@ -1,29 +0,0 @@
- 
import { test, expect } from "@tests/support/fixtures.js";
-
- 
test("change httpd port", async ({ page, peerManager }) => {
- 
  const peer = await peerManager.startPeer({ name: "httpd" });
-
- 
  await peer.startHttpd(8070);
- 
  await peer.startNode();
-
- 
  await page.goto("/");
- 
  await page.getByRole("button", { name: "radicle.local" }).click();
-
- 
  await page.locator('input[name="port"]').fill("8070");
- 
  await page.locator('input[name="port"]').press("Enter");
-
- 
  const { stdout } = await peer.rad([
- 
    "web",
- 
    "--frontend",
- 
    "http://localhost:3000",
- 
    "--backend",
- 
    "http://127.0.0.1:8070",
- 
  ]);
- 
  const match = stdout.trim().match(/(http:\/\/localhost:3000\/.*)$/);
- 
  if (!match) {
- 
    throw Error("Not able to parse auth url");
- 
  }
- 
  await page.goto(match[0]);
- 
  await expect(page.getByText("Authenticated")).toBeVisible();
- 
  await expect(page).toHaveURL("/seeds/127.0.0.1:8070");
- 
});
modified tests/e2e/project/issues.spec.ts
@@ -55,3 +55,70 @@ test("test issue editing failing", async ({ page, authenticatedPeer }) => {
  await page.getByRole("button", { name: "Comment" }).click();

  await expect(page.getByText("Issue editing failed")).toBeVisible();

});
+
+ 
test("go through the entire ui issue flow", async ({
+ 
  page,
+ 
  authenticatedPeer,
+ 
}) => {
+ 
  const { rid } = await createProject(authenticatedPeer, "commenting");
+
+ 
  await page.goto(`/seeds/127.0.0.1:8070/${rid}`);
+ 
  await page.getByRole("link", { name: "0 issues" }).click();
+ 
  await page.getByRole("link", { name: "New issue" }).click();
+ 
  await page.getByPlaceholder("Title").fill("This is a title");
+ 
  await page
+ 
    .getByPlaceholder("Write a description")
+ 
    .fill("This is a description");
+
+ 
  await page.getByPlaceholder("Add assignee").fill(authenticatedPeer.nodeId);
+ 
  await page.getByPlaceholder("Add assignee").press("Enter");
+
+ 
  await page.getByPlaceholder("Add tag").fill("bug");
+ 
  await page.getByPlaceholder("Add tag").press("Enter");
+ 
  await page.getByPlaceholder("Add tag").fill("documentation");
+ 
  await page.getByPlaceholder("Add tag").press("Enter");
+
+ 
  await page.getByRole("button", { name: "Submit" }).click();
+
+ 
  await expect(page.getByText("This is a title")).toBeVisible();
+ 
  await expect(page.getByText("This is a description")).toBeVisible();
+ 
  await expect(
+ 
    page.getByLabel("chip").filter({
+ 
      hasText: `did:key:${authenticatedPeer.nodeId.substring(
+ 
        0,
+ 
        6,
+ 
      )}…${authenticatedPeer.nodeId.slice(-6)}`,
+ 
    }),
+ 
  ).toBeVisible();
+ 
  await expect(
+ 
    page.getByLabel("chip").filter({ hasText: "documentation" }),
+ 
  ).toBeVisible();
+ 
  await expect(
+ 
    page.getByLabel("chip").filter({ hasText: "bug" }),
+ 
  ).toBeVisible();
+
+ 
  await page.getByRole("button", { name: "edit" }).first().click();
+ 
  await page.getByPlaceholder("Title").fill("This is a new title");
+ 
  await page.getByRole("button", { name: "save" }).click();
+ 
  await expect(page.getByText("This is a new title")).toBeVisible();
+
+ 
  await page.getByPlaceholder("Leave your comment").fill("This is a comment");
+ 
  await page.getByRole("button", { name: "Comment" }).click();
+ 
  await expect(page.getByText("This is a comment")).toBeVisible();
+
+ 
  await page.getByRole("button", { name: "reply" }).click();
+ 
  await page.getByPlaceholder("Leave your reply").fill("This is a reply");
+ 
  await page.getByRole("button", { name: "Reply", exact: true }).click();
+ 
  await expect(page.getByText("This is a reply")).toBeVisible();
+
+ 
  await page.getByRole("button", { name: "Close issue as solved" }).click();
+ 
  await expect(page.getByText("closed as solved")).toBeVisible();
+
+ 
  await page.getByRole("button", { name: "Reopen issue" }).click();
+ 
  await expect(page.getByText("open", { exact: true })).toBeVisible();
+
+ 
  await page.getByRole("button", { name: "stateToggle" }).click();
+ 
  await page.getByText("Close issue as other").click();
+ 
  await page.getByRole("button", { name: "Close issue as other" }).click();
+ 
  await expect(page.getByText("closed as other")).toBeVisible();
+ 
});
modified tests/support/fixtures.ts
@@ -14,6 +14,7 @@ import * as patch from "@tests/support/cobs/patch.js";
import { createOptions, supportDir, tmpDir } from "@tests/support/support.js";

import { createPeerManager } from "@tests/support/peerManager.js";

import { createProject } from "@tests/support/project.js";
+ 
import { object, string, ZodSchema } from "zod";



export { expect };
@@ -21,6 +22,18 @@ const fixturesDir = Path.resolve(supportDir, "..", "./fixtures");


type ViewportTypes = "iPhoneXR" | "Desktop";
+ 
interface Auth {
+ 
  sessionId: string;
+ 
  publicKey: string;
+ 
  signature: string;
+ 
}
+
+ 
const authSchema = object({
+ 
  sessionId: string(),
+ 
  publicKey: string(),
+ 
  signature: string(),
+ 
}) satisfies ZodSchema<Auth>;
+ 


export const viewportSizes: Record<ViewportTypes, ViewportSize> = {

  iPhoneXR: { width: 414, height: 896 },

  Desktop: { width: 1280, height: 720 },
@@ -164,15 +177,24 @@ export const test = base.extend<{
      "http://localhost:3000",

      "--backend",

      "http://127.0.0.1:8070",
+ 
      "--json",

    ]);
- 
    const match = stdout.trim().match(/(http:\/\/localhost:3000\/.*)$/);
- 
    if (!match) {
- 
      throw Error("Not able to parse auth url");
+ 
    const result = authSchema.safeParse(JSON.parse(stdout));
+ 
    if (result.success) {
+ 
      const { sessionId, publicKey, signature } = result.data;
+ 
      await page.goto(
+ 
        `http://localhost:3000/session/${sessionId}?pk=${publicKey}&sig=${signature}`,
+ 
      );
+ 
      await expect(page.getByText("Authenticated")).toBeVisible();
+ 
      await page.getByRole("button", { name: "Close" }).click();
+ 
    } else {
+ 
      throw new Error("Not able to parse rad web output");

    }
- 
    await page.goto(match[0]);
- 
    await page.getByRole("button", { name: "Close" }).click();



    await use(peer);
+
+ 
    await peer.stopHttpd(8070);
+ 
    await peer.stopNode();

  },



  // eslint-disable-next-line no-empty-pattern