7d61539 Renaming confusing method `startPeer` to `createPeer` — radicle-explorer

Radicle web interface

Renaming confusing method `startPeer` to `createPeer`

Thomas Scholtes committed 2 years ago

commit 7d61539d95fcea345454720047d64059b08f250a
parent f2eb867d1f7bcd0581dc113f959491cf3ada9431

7 files changed +13 -13

modified httpd-client/tests/session.test.ts

@@ -16,7 +16,7 @@ describe("session", async () => {

       Path.join(tmpDir, "peerManager.log"),
     ).setMaxListeners(16),
   });
   const peer = await peerManager.startPeer({
   const peer = await peerManager.createPeer({
     name: "session",
     gitOptions: gitOptions["alice"],
   });

modified httpd-client/tests/support/fixtures.ts

@@ -20,7 +20,7 @@ export const testFixture = test.extend<TestFixtures>({

         Path.join(tmpDir, "peerManager.log"),
       ).setMaxListeners(16),
     });
     const peer = await peerManager.startPeer({
     const peer = await peerManager.createPeer({
       name: "palm",
       gitOptions: gitOptions["alice"],
     });

modified tests/e2e/node.spec.ts

@@ -7,7 +7,7 @@ import {

 } from "@tests/support/fixtures.js";
 test("node metadata", async ({ page, peerManager }) => {
   const peer = await peerManager.startPeer({
   const peer = await peerManager.createPeer({
     name: "node-metadata-peer",
   });
   await peer.startHttpd();

modified tests/e2e/project/commits.spec.ts

@@ -126,7 +126,7 @@ test("relative timestamps", async ({ page }) => {

 });
 test("pushing changes while viewing history", async ({ page, peerManager }) => {
   const alice = await peerManager.startPeer({
   const alice = await peerManager.createPeer({
     name: "alice",
     gitOptions: gitOptions["alice"],
   });

modified tests/support/fixtures.ts

@@ -159,7 +159,7 @@ export const test = base.extend<{

   },
   authenticatedPeer: async ({ page, peerManager }, use) => {
     const peer = await peerManager.startPeer({
     const peer = await peerManager.createPeer({
       name: "httpd",
       gitOptions: gitOptions["bob"],
     });

@@ -288,12 +288,12 @@ export async function createSourceBrowsingFixture(

     sourceBrowsingDir,
   ]);
   const rid = sourceBrowsingRid;
   const alice = await peerManager.startPeer({
   const alice = await peerManager.createPeer({
     name: "alice",
     gitOptions: gitOptions["alice"],
   });
   const aliceProjectPath = Path.join(alice.checkoutPath, "source-browsing");
   const bob = await peerManager.startPeer({
   const bob = await peerManager.createPeer({
     name: "bob",
     gitOptions: gitOptions["bob"],
   });

modified tests/support/globalSetup.ts

@@ -45,7 +45,7 @@ export default async function globalSetup(): Promise<() => void> {

       .setMaxListeners(16),
   });
   const palm = await peerManager.startPeer({
   const palm = await peerManager.createPeer({
     name: "palm",
     gitOptions: gitOptions["alice"],
   });

modified tests/support/peerManager.ts

@@ -72,7 +72,7 @@ interface PeerManagerParams {

 }
 export interface PeerManager {
   startPeer(params: {
   createPeer(params: {
     name: string;
     gitOptions?: Record<string, string>;
   }): Promise<RadiclePeer>;

@@ -98,17 +98,17 @@ export async function createPeerManager(createParams: {

     outputLog = outputLogFile.createWriteStream();
   }
   const nodes: RadiclePeer[] = [];
   const peers: RadiclePeer[] = [];
   return {
     async startPeer(params) {
     async createPeer(params) {
       const peer = await RadiclePeer.create({
         dataPath: createParams.dataDir,
         name: params.name,
         gitOptions: params.gitOptions,
         node: generateNode(nodes.length + 1),
         node: generateNode(peers.length + 1),
         outputLog,
       });
       nodes.push(peer);
       peers.push(peer);
       return peer;
     },