492ff5b Properly handle event streams with readline — radicle-explorer

Radicle web interface

Properly handle event streams with readline

Rūdolfs Ošiņš committed 2 years ago

commit 492ff5b07c6457b0b4b0d05e331cce968f598022
parent 5736083d50be18bb9216db4bf83d6742ff44aaae

1 file changed +20 -18

modified tests/support/peerManager.ts

@@ -10,6 +10,7 @@ import getPort from "get-port";

 import lodash from "lodash";
 import waitOn from "wait-on";
 import { execa } from "execa";
 import * as readline from "node:readline/promises";
 import * as Process from "./process.js";
 import { randomTag } from "@tests/support/support.js";

@@ -292,24 +293,25 @@ export class RadiclePeer {

       resources: [`socket:${this.#socket}`],
     });
     this.rad(["node", "events"], { cwd: this.#radHome }).stdout?.on(
       "data",
       (data: any) => {
         data
           .toString()
           .split("\n")
           .forEach((data: unknown) => {
             if (data && typeof data === "string" && data.trim() !== "") {
               try {
                 const result: NodeEvent = JSON.parse(data);
                 this.#eventRecords.push(result);
               } catch (e) {
                 console.log("Error parsing event", data);
               }
             }
           });
       },
     );
     const stdout = this.rad(["node", "events"], { cwd: this.#radHome }).stdout;
     if (stdout) {
       readline
         .createInterface({
           input: stdout,
           terminal: false,
         })
         .on("line", line => {
           try {
             const result: NodeEvent = JSON.parse(line);
             this.#eventRecords.push(result);
           } catch (e) {
             console.log("Error parsing event", line);
           }
         });
     } else {
       throw new Error("Could not get stdout to track events");
     }
   }
   public async stopNode() {