Radish alpha
r
radicle-explorer
rad:z4V1sjrXqjvFdnCUbxPFqd5p4DtH5
Radicle web interface
Radicle
Git
Commits › 144fc42
fix(web): Provide visual response to old reviews
Samuel Shuert committed 1 year ago
commit 144fc4297053428f0533611b220ac35fa4a18740
parent 5657a6f
1 file changed +21 -3
modified src/views/repos/Cob/Reviews.svelte
@@ -7,6 +7,16 @@


  export let baseUrl: BaseUrl;

  export let reviews: PatchReviews;
+
+ 
  $: sortedReviews = Array.from(Object.values(reviews)).sort((a, b) => {
+ 
    if (a.latest === b.latest) {
+ 
      return 0;
+ 
    } else if (b.latest) {
+ 
      return 1;
+ 
    } else {
+ 
      return -1;
+ 
    }
+ 
  });

</script>



<style>
@@ -21,7 +31,6 @@
    font-size: var(--font-size-small);

  }

  .review {
- 
    color: var(--color-fill-gray);

    display: inline-flex;

    align-items: center;

    gap: 0.5rem;
@@ -32,6 +41,10 @@
  .review-reject {

    color: var(--color-foreground-red);

  }
+ 
  .txt-missing .review-accept,
+ 
  .txt-missing .review-reject {
+ 
    color: var(--color-foreground-dim);
+ 
  }

  @media (max-width: 1349.98px) {

    .wrapper {

      display: flex;
@@ -58,8 +71,13 @@
<div class="wrapper">

  <div class="header">Reviews</div>

  <div class="body">
- 
    {#each Object.values(reviews) as { latest, review }}
- 
      <div class="review" class:txt-missing={!latest}>
+ 
    {#each sortedReviews as { latest, review }}
+ 
      <div
+ 
        class="review"
+ 
        class:txt-missing={!latest}
+ 
        title={!latest
+ 
          ? `This review was on a previous revision. Please ask ${review.author.alias} to re-review`
+ 
          : ""}>

        <span

          class:review-accept={review.verdict === "accept"}

          class:review-reject={review.verdict === "reject"}>