069b094 Enable the @typescript-eslint/no-floating-promises rule — radicle-explorer

Radicle web interface

Enable the @typescript-eslint/no-floating-promises rule

Rūdolfs Ošiņš committed 3 years ago

commit 069b0949d554d7673a05b27b7ee8bf9ffb9c0688
parent 2d58c600ad28b07772c97fc16bac5d6c4ce8bc0d

4 files changed +6 -4

modified .eslintrc.json

@@ -8,7 +8,8 @@

   "parser": "@typescript-eslint/parser",
   "parserOptions": {
     "ecmaVersion": 2020,
     "sourceType": "module"
     "sourceType": "module",
     "project": ["./tsconfig.json"]
   },
   "plugins": ["svelte3", "@typescript-eslint"],
   "overrides": [

@@ -49,6 +50,7 @@

     ],
     "eol-last": ["error"],
     "key-spacing": ["error"],
     "@typescript-eslint/no-floating-promises": "error",
     "@typescript-eslint/object-curly-spacing": ["error", "always"],
     "@typescript-eslint/type-annotation-spacing": ["error"],
     "@typescript-eslint/naming-convention": [

modified tests/e2e/project.spec.ts

@@ -72,7 +72,7 @@ test("show source tree at specific revision", async ({ page }) => {

   await expect(page.getByTitle("Current branch")).toContainText(
     "335dd6dc89b535a4a31e9422c803199bb6b0a09a",
   );
   expect(page.locator(".source-tree")).toHaveText("bin/ src/");
   await expect(page.locator(".source-tree")).toHaveText("bin/ src/");
   await expectCounts({ commits: 2, contributors: 1 }, page);
 });

modified tests/support/globalSetup.ts

@@ -3,7 +3,7 @@ import type { FullConfig } from "@playwright/test";

 import { seedPort, seedRemote } from "@tests/support/fixtures.js";
 export default async function globalSetup(_config: FullConfig): Promise<void> {
   assertHttpApiRunning();
   await assertHttpApiRunning();
 }
 // Assert that the test http-api is running. If it is not running, throw an

modified tsconfig.json

@@ -1,6 +1,6 @@

 {
   "extends": "@tsconfig/svelte/tsconfig.json",
   "include": ["src", "tests", "httpd-client"],
   "include": ["src", "tests", "httpd-client", "./*.js", "./*.ts"],
   "exclude": ["node_modules/*"],
   "compilerOptions": {
     "target": "es2020",