Add discussion section to reviews — radicle-desktop

radicle-desktop

rad:z4D5UCArafTzTQpDZNQRuqswh3ury

Radicle desktop app

Add discussion section to reviews

Merged rudolfs opened 1 year ago

TBD: margin styling to align the discussion section in the Issue and Review views. The rest is ready for review :)

👉 Workflow runs 👉 Branch on GitHub

Activity Changes +0 -0

rudolfs opened with revision e85e8b2c on base 4add00d6 +335 -185 1 year ago

TBD: margin styling to align the discussion section in the Issue and Review views. The rest is ready for review :)

👉 Workflow runs 👉 Branch on GitHub

rudolfs pushed revision 2 72417856 on base 4add00d6 +350 -262 1 year ago

Refactor Issue discussion section

We now use the Discussion component like everywhere else.

rudolfs pushed revision 3 e4eb924d on base 4add00d6 +367 -271 1 year ago

Fix participants section

make it reactive
only show unique participants
show them in one line

did:key:z6MkkfM3...sVz5 reviewed · 1 comment 1 year ago

Nice work, code LGTM so far. There is one e2e tests that is failing: repo/issue.spec.ts:32:1 › creation of top level comments

One small thing I noticed is that when expanding/collapsing the discussion section we get a little bit of moving there. I checked on the revision discussions and we don’t have that moving there.

output.mp4

rudolfs pushed revision 4 ea95ec88 on base 15bb0353 +367 -271 1 year ago

Rebase

rudolfs pushed revision 5 eee9e0cd on base 15bb0353 +370 -274 1 year ago

Fix specs

rudolfs pushed revision 6 7685420d on base 15bb0353 +370 -274 1 year ago

Fix discussion section margin jumping

rudolfs merged revision 7685420d at 2e6fed98 1 year ago