Instead of allowing users to click on left and right side of diff lines, we only should allow people to select on the available side.
If we have README.md:L1 but no R1 we shouldn’t allow users to write a comment on README.md:R1 since this will fail.
Instead of allowing users to click on left and right side of diff lines, we only should allow people to select on the available side.
If we have README.md:L1 but no R1 we shouldn’t allow users to write a comment on README.md:R1 since this will fail.
Woodpecker pipeline #449 current status: created. ⏳
- Details: https://woodpecker.radworks.garden/repos/6/pipeline/111
Woodpecker pipeline #449 current status: created. ⏳
- Details: https://woodpecker.radworks.garden/repos/6/pipeline/111
Woodpecker pipeline #449 completed with status: success. ✅
- Details: https://woodpecker.radworks.garden/repos/6/pipeline/111
I just read the patch description, didn’t look at the code yet.
I thought that’s what I had implemented, regardless of where you click, it should only add the comment on the side that is possible. I.e. if you click on the right side of a deletion or left side of an addition it should add the comment to the correct side. I also couldn’t reproduce it by clicking around.
nvmnd, could repro
regardless of where you click
I think if we could solve it like that, it would be the best solution.
Here’s the patch for that: https://app.radicle.xyz/nodes/seed.radicle.xyz/rad:z4D5UCArafTzTQpDZNQRuqswh3ury/patches/a9775bd658bdc53a86c425eebefff94cc1f585af