Radish alpha
r
rad:z4D5UCArafTzTQpDZNQRuqswh3ury
Radicle desktop app
Radicle
Git
Add button to delete draft reviews
Merged did:key:z6Mki9XN...FvWF opened 9 months ago

Also introduces update functions for less error-prone local storage updates

For local storage updates to be persisted it had to be assigned for example with storage.value = storage.value. It was easy to forget this and it’s not immediately obvious why this is needed. (In fact, eslint complains.)

did:key:z6Mki9XN...FvWF opened with revision be9d2a1f on base ceca51c1 +124 -69 9 months ago

Also introduces update functions for less error-prone local storage updates

For local storage updates to be persisted it had to be assigned for example with storage.value = storage.value. It was easy to forget this and it’s not immediately obvious why this is needed. (In fact, eslint complains.)

did:key:z6Mki4CG...o5Zr commented on revision 1 9 months ago

Woodpecker pipeline #1157 current status: created. ⏳

  • Details: https://woodpecker.radworks.garden/repos/6/pipeline/639
did:key:z6Mki4CG...o5Zr commented on revision 1 9 months ago

Woodpecker pipeline #1157 current status: created. ⏳

  • Details: https://woodpecker.radworks.garden/repos/6/pipeline/639
did:key:z6Mki4CG...o5Zr commented on revision 1 9 months ago

Woodpecker pipeline #1157 current status: created. ⏳

  • Details: https://woodpecker.radworks.garden/repos/6/pipeline/639
did:key:z6Mki4CG...o5Zr commented on revision 1 9 months ago

Woodpecker pipeline #1157 current status: created. ⏳

  • Details: https://woodpecker.radworks.garden/repos/6/pipeline/639
did:key:z6Mki4CG...o5Zr commented on revision 1 9 months ago

Woodpecker pipeline #1157 current status: created. ⏳

  • Details: https://woodpecker.radworks.garden/repos/6/pipeline/639
did:key:z6Mki4CG...o5Zr commented on revision 1 9 months ago

Woodpecker pipeline #1157 completed with status: success. ✅

  • Details: https://woodpecker.radworks.garden/repos/6/pipeline/639
rudolfs reviewed 9 months ago

Looks great. Could we use this icon instead of the cross?

diff --git a/src/components/Comment.svelte b/src/components/Comment.svelte
index dc22d3e..27c4f91 100644
--- a/src/components/Comment.svelte
+++ b/src/components/Comment.svelte
@@ -163,7 +163,7 @@
         {/if}
         {#if deleteComment}
           <div class="icon-button">
-            <Icon name="cross" onclick={deleteComment} />
+            <Icon name="trash" onclick={deleteComment} />
           </div>
         {/if}
         {#if reactions && reactOnComment}
diff --git a/src/components/Icon.svelte b/src/components/Icon.svelte
index b454f7a..9711f3e 100644
--- a/src/components/Icon.svelte
+++ b/src/components/Icon.svelte
@@ -82,6 +82,7 @@
       | "stop"
       | "sun"
       | "thumb-up"
+      | "trash"
       | "unresolve"
       | "user"
       | "warning";
@@ -1398,6 +1399,15 @@
     <path d="M7 6H8V7H7L7 6Z" />
     <path d="M7 10L8 10V11L7 11L7 10Z" />
     <path d="M7 12L8 12L8 13H7L7 12Z" />
+  {:else if name === "trash"}
+    <path d="M6.5 2L9.5 2V3L6.5 3V2Z" />
+    <path d="M3.5 5H4.5L4.5 13H3.5L3.5 5Z" />
+    <path d="M4.5 13L11.5 13V14L4.5 14V13Z" />
+    <path d="M11.5 5L12.5 5L12.5 13H11.5L11.5 5Z" />
+    <path d="M2.5 3L13.5 3V4L2.5 4L2.5 3Z" />
+    <path d="M9.5 5H10.5L10.5 12L9.5 12V5Z" />
+    <path d="M7.5 5L8.5 5V12H7.5L7.5 5Z" />
+    <path d="M5.5 5H6.5L6.5 12H5.5L5.5 5Z" />
   {:else if name === "unresolve"}
     <path d="M7 11.5V12.5H6V11.5H7Z" />
     <path d="M8 10.5V11.5L7 11.5L7 10.5H8Z" />
diff --git a/src/components/Review.svelte b/src/components/Review.svelte
index 42a4a94..66881ee 100644
--- a/src/components/Review.svelte
+++ b/src/components/Review.svelte
@@ -377,7 +377,7 @@
               status: undefined,
             });
           }}>
-          <Icon name="cross" />Delete
+          <Icon name="trash" />Delete
         </Button>
         <Button
           styleHeight="2.5rem"

did:key:z6Mki9XN...FvWF pushed revision 2 dae6e073 on base ceca51c1 +135 -70 9 months ago
rudolfs accepted 9 months ago
rudolfs pushed revision 3 29cccf94 on base ceca51c1 +135 -70 9 months ago

Change button styling

rudolfs merged revision 29cccf94 at ea395ee8 9 months ago