Radish alpha
r
rad:z4D5UCArafTzTQpDZNQRuqswh3ury
Radicle desktop app
Radicle
Git
Implement a custom `list_patches` method to read directly from cache
Merged did:key:z6MkkfM3...sVz5 opened 1 year ago

Instead of generating a paginated result from an unsorted list of patches, we should try to sort all patches (and issues in a follow up) by their latest timestamp on the database and then in the tauri command paginate the sorted list, so we can provide a infinite loading with a natural order.

In a follow up it would probably also make sense to generate sql statements according to the thing we want cobs to order by

did:key:z6MkkfM3...sVz5 opened with revision b8fb6fa4 on base c4bef0e9 +740 -587 1 year ago

Instead of generating a paginated result from an unsorted list of patches, we should try to sort all patches (and issues in a follow up) by their latest timestamp on the database and then in the tauri command paginate the sorted list, so we can provide a infinite loading with a natural order.

In a follow up it would probably also make sense to generate sql statements according to the thing we want cobs to order by

did:key:z6MkkfM3...sVz5 commented on revision 1 1 year ago

@rudolfs so one thing I realized with this patch, is that I’m sorting patches by the last revision on each patch, which in itself is a nice feature.

The other option would be to sort by the first revision which opened the patch, but this would mean that sometimes a new revision to a patch would still not show up on the top.

wdyt?

EDIT: Ok so I pushed revision 81e5088 which changes this so we order by the timestamp a patch as been opened at.

did:key:z6MkkfM3...sVz5 pushed revision 2 81e50882 on base c4bef0e9 +740 -587 1 year ago

Okay so I changed my mind and I think that we should sort the patches by the timestamp when they have been opened and not when the last revision on them happened.

rudolfs commented on revision 1 1 year ago

EDIT: Ok so I pushed revision 81e5088 which changes this so we order by the timestamp a patch as been opened at.

Think this makes the most sense.

rudolfs pushed revision 3 af223f87 on base 038a21cb +740 -587 1 year ago

Rebase.

rudolfs commented on revision 1 1 year ago

Build is failing though. Otherwise code and functionality LGTM.

check check-e2e

šŸ‘‰ Workflow runs šŸ‘‰ Branch on GitHub

did:key:z6MkkfM3...sVz5 pushed revision 4 3fecaa2a on base 038a21cb +784 -596 1 year ago

Fix e2e tests

did:key:z6MkkfM3...sVz5 commented on revision 1 1 year ago

Okay so tests are passing now

rudolfs accepted 1 year ago
rudolfs merged revision 3fecaa2a at f34522b6 1 year ago