Radish alpha
r
rad:z4D5UCArafTzTQpDZNQRuqswh3ury
Radicle desktop app
Radicle
Git
Convert cob actions into customized desktop actions
Merged did:key:z6MkkfM3...sVz5 opened 1 year ago

This commit allows us to e.g. convert the Set of DIDs we obtain from assignee actions on cobs into a Set of Authors with their Aliases.

Also it introduces the FromRadicleAction trait which can be implemented for any type of enum we get from the radicle create to convert into a type which is better suited for us.

Removes also any calling the alias command in the PatchTimeline or IssueTimeline since we already get the alias from the backend the first time now.

Also does the following:

  • Remove unused logging statements
  • Change some eprintln statements for log::error

This partially solves issue 337f765acff2fac32ea4c5ea26e0852c7bc6bddc

checkcheck-unit-testcheck-e2e

👉 Workflow runs 👉 Branch on GitHub

did:key:z6MkkfM3...sVz5 opened with revision 9bc5a6c0 on base 6ca5f296 +282 -91 1 year ago

This commit allows us to e.g. convert the Set of DIDs we obtain from assignee actions on cobs into a Set of Authors with their Aliases.

Also it introduces the FromRadicleAction trait which can be implemented for any type of enum we get from the radicle create to convert into a type which is better suited for us.

Removes also any calling the alias command in the PatchTimeline or IssueTimeline since we already get the alias from the backend the first time now.

Also does the following:

  • Remove unused logging statements
  • Change some eprintln statements for log::error

This partially solves issue 337f765acff2fac32ea4c5ea26e0852c7bc6bddc

checkcheck-unit-testcheck-e2e

👉 Workflow runs 👉 Branch on GitHub

rudolfs reviewed 1 year ago

The assignee editing feature is broken now on issue, new issue, patch views (shame on me for not writing tests):

Editing assignees failed
"invalid args `action` for command `edit_issue`: invalid type: string \"did:key:z6MkfgZKQgtWtgNsVizqWqFKf6ka7oo8vS8mppKDVhDM5YMm\", expected struct Author"
levitte reviewed 1 year ago
did:key:z6MkkfM3...sVz5 pushed revision 2 0f48bd60 on base 7cf21972 +283 -92 1 year ago

Fix edit assignees in issues

rudolfs pushed revision 3 82d07f97 on base 47ea7d78 +283 -92 1 year ago

Rebase

rudolfs accepted 1 year ago

Nice work Sebastian!

rudolfs merged revision 82d07f97 at c730e821 1 year ago