Add short commit hash in about popup for macOS build — radicle-desktop

rad:z4D5UCArafTzTQpDZNQRuqswh3ury

Radicle desktop app

Add short commit hash in about popup for macOS build

Merged did:key:z6MkkfM3...sVz5 opened 1 year ago

This adds a new release file to the root folder where we store the current version of the app.
A new scripts/release script that updates the tauri.conf.json and Info.plist file to get a shortened commit hash of the head the app was built on.
- Only tested on macOS, we need some testing how we can expose this on other operating systems.

did:key:z6MkkfM3...sVz5 opened with revision 7bebb1ac on base f0ef0872 +29 -2 1 year ago

This adds a new release file to the root folder where we store the current version of the app.
A new scripts/release script that updates the tauri.conf.json and Info.plist file to get a shortened commit hash of the head the app was built on.
- Only tested on macOS, we need some testing how we can expose this on other operating systems.

did:key:z6Mki4CG...o5Zr commented on revision 1 1 year ago

Woodpecker pipeline #425 current status: created. ⏳

did:key:z6Mki4CG...o5Zr commented on revision 1 1 year ago

Woodpecker pipeline #425 current status: created. ⏳

did:key:z6Mki4CG...o5Zr commented on revision 1 1 year ago

Woodpecker pipeline #425 completed with status: success. ✅

did:key:z6MkkfM3...sVz5 pushed revision 2 d3cc795b on base f0ef0872 +29 -2 1 year ago

Replace hard coded commit hash in Info.plist with __VERSION__

did:key:z6Mki4CG...o5Zr commented on revision 2 1 year ago

Woodpecker pipeline #426 current status: created. ⏳

did:key:z6Mki4CG...o5Zr commented on revision 2 1 year ago

Woodpecker pipeline #426 current status: created. ⏳

did:key:z6Mki4CG...o5Zr commented on revision 2 1 year ago

Woodpecker pipeline #426 completed with status: success. ✅

rudolfs reviewed · 2 comments 1 year ago

Just read over the code, didn’t test yet.

Could we:

update the RELEASE.md checklist to make sure we update the right version file
also bake the version + latest commit sha into the in-app Settings popover during build

did:key:z6MkkfM3...sVz5 pushed revision 3 02bd4f15 on base f0ef0872 +71 -7 1 year ago

Improve baking in

Changes:

Instead of having an additional release file we could rely solely on tauri.conf.json
Instead of running a shell script we can bake the values in the build.rs file and then query from the frontend the static values, so we don’t have to handle vite and env variables.
- Also allows us to access them from other implementations like test-http-api, or other crates.
I simplified also some npm run scripts IMO, but open to revert that

rudolfs reviewed · 2 comments 0 years ago

I simplified also some npm run scripts IMO, but open to revert that

Yeah, I liked how it was before, kinda what you’re used from a tauri project. Maybe let’s revert that.

Left an inline comment. The other changes are a nice improvement!

did:key:z6MkkfM3...sVz5 pushed revision 4 37161da7 on base f0ef0872 +61 -2 0 years ago

Revert changes to npm run scripts and addressed line comment in Settings.svelte file

rudolfs accepted 0 years ago

rudolfs merged revision 37161da7 at 865497ce 0 years ago