Implement code comments for single line selections — radicle-desktop

Radicle desktop app

Implement code comments for single line selections

✓ 1/1 checks passed rudolfs wants to merge 10 commits into main · opened 1 year ago

✓ All checks passed — 1 passed View logs ↗

rudolfs opened with revision 6024af253191690c40263beec5821c19a4474b4b on base 0efb4e09f799f103c6339df54f689c5a7a817d78 +1146 -657 1 year ago

rudolfs pushed revision 2 c9db882b689953450c96d9859051f8fb55b0dd35 on base 0efb4e09f799f103c6339df54f689c5a7a817d78 +1146 -657 1 year ago

Cleanup

sebastinez reviewed 1 year ago

sebastinez reviewed · 16 comments 1 year ago

Nice work! Love to be able to add line comments, left some comments in the discussion thread to make use of embeds. I think for something to show to eventual customers this is already awesome!

rudolfs pushed revision 3 2a77e5a8b1db64b2a588215d56469beaf1c4ba1f on base 0efb4e09f799f103c6339df54f689c5a7a817d78 +1143 -659 1 year ago

Address code review comments

rudolfs pushed revision 4 0e45e3e6bcd9676770f780cf536799e634d7dfcc on base 7cf21972cdcfecf235700519d6e1cc85d7c89bc1 +1143 -659 1 year ago

Rebase

rudolfs pushed revision 5 1c9cfc810a06c02493f8fa4128259ce162b3dbf0 on base 7cf21972cdcfecf235700519d6e1cc85d7c89bc1 +1154 -660 1 year ago

Fix review always showing code of latest revision

rudolfs pushed revision 6 f967b3ca8d04ea311762b2c5fa2f7889aa944a6a on base 7cf21972cdcfecf235700519d6e1cc85d7c89bc1 +1144 -660 1 year ago

Show commit list in review view

rudolfs pushed revision 7 66f4405e304d6b8360023050f6a37e812fb2b00c on base 7cf21972cdcfecf235700519d6e1cc85d7c89bc1 +1154 -663 1 year ago

Fix routing bugs

rudolfs pushed revision 8 cffb6ea7a7f6a25f2a184ac032a4d990db90000d on base 7cf21972cdcfecf235700519d6e1cc85d7c89bc1 +1194 -676 1 year ago

Fix router issues

rudolfs pushed revision 9 606cf458d883551ccebfb6381ed045d20aedaaed on base 7cf21972cdcfecf235700519d6e1cc85d7c89bc1 +1140 -675 1 year ago

Close comment input after submitting line comment

rudolfs pushed revision 10 6e00664a832bc9525796ab990525fdec08ec0911 on base 7cf21972cdcfecf235700519d6e1cc85d7c89bc1 +1228 -721 1 year ago

Style code comments properly

rudolfs pushed revision 11 8bbf8bf2f4cafd7a9bd624b2aa2e10085942460b on base 7cf21972cdcfecf235700519d6e1cc85d7c89bc1 +1230 -717 1 year ago

Fix review loading