Radish alpha
r
rad:z4D5UCArafTzTQpDZNQRuqswh3ury
Radicle desktop app
Radicle
Git
fix: show all repos if specified
Archived did:key:z6MkgFWv...1Lu7 opened 1 year ago

The conditional was skipping repositories that didn’t have own refs if Show::All was specified. I assume the opposite is the intended behavior.

did:key:z6MkgFWv...1Lu7 opened with revision 5f4e8635 on base 9235f186 +1 -1 1 year ago

The conditional was skipping repositories that didn’t have own refs if Show::All was specified. I assume the opposite is the intended behavior.

did:key:z6MkkfM3...sVz5 reviewed 1 year ago

So the idea behind Show::All was to mimick rad ls, which as specified in the help message does the following.

By default, this command shows you all repositories that you have forked or initialized.

So the code is doing what it is intended to do.

Now based on my own issue (e398f7fc5cce84e76fe6f0ea6a9f49481ef11724), that I opened due to users not being able to see repos they cloned. I suggest we can either remove the check for a own namespace in a repo all together, or maybe change Show::All to Show::Contributor.

rudolfs commented on revision 1 1 year ago

I think we initially wanted to mirror the CLI tooling behaviour, just so it’s consistent. But I agree that it makes more sense to just show everything. We can do the filtering in-app in the sidebar.

rudolfs commented on revision 1 1 year ago

We resolved this with 85dd21c6cfe7bca62a3eec86a0601221ad16dba2, so I’m going to archive this one. Thanks for the initiative tho!