Radish alpha
r
rad:z4D5UCArafTzTQpDZNQRuqswh3ury
Radicle desktop app
Radicle
Git
Fix some issues with draft patch reviews
Merged did:key:z6MkkfM3...sVz5 opened 1 year ago

This patch adds a New Review button into the patch section, that allows users to create a new draft patch review for a specific revision on a specific patch. Once the user created a review, he shouldn’t be able to create a new review on the same patch and revision.

Once the review which is usually in a draft state (not synced with other nodes) is ready for publishing, the user should click on the publish button available for reviews in draft state. Which would remove the draft object and update the patch to have the new patch revision review.

In case that a patch has older reviews by the same issue, we need to make sure that we only show draft reviews for the correct revision.

checkcheck-unit-testcheck-e2e

👉 Workflow runs 👉 Branch on GitHub

did:key:z6MkkfM3...sVz5 opened with revision 460bf66d on base f34522b6 +343 -71 1 year ago

This patch adds a New Review button into the patch section, that allows users to create a new draft patch review for a specific revision on a specific patch. Once the user created a review, he shouldn’t be able to create a new review on the same patch and revision.

Once the review which is usually in a draft state (not synced with other nodes) is ready for publishing, the user should click on the publish button available for reviews in draft state. Which would remove the draft object and update the patch to have the new patch revision review.

In case that a patch has older reviews by the same issue, we need to make sure that we only show draft reviews for the correct revision.

checkcheck-unit-testcheck-e2e

👉 Workflow runs 👉 Branch on GitHub

did:key:z6MkkfM3...sVz5 pushed revision 2 173b1ce4 on base f34522b6 +337 -71 1 year ago

Remove $inspect calls

rudolfs pushed revision 3 573445ae on base f34522b6 +337 -71 1 year ago

Fix lint

rudolfs rejected 1 year ago
rudolfs pushed revision 4 75f9c34e on base f238f247 +341 -72 1 year ago

Rebase.

rudolfs rejected 1 year ago
did:key:z6MkkfM3...sVz5 pushed revision 5 1f23b2c6 on base 622585af +170 -312 1 year ago

Rebase, address feedback and remove DraftStore

rudolfs accepted 1 year ago
rudolfs merged revision 1f23b2c6 at 0338e96d 1 year ago