Radish alpha
r
rad:z4D5UCArafTzTQpDZNQRuqswh3ury
Radicle desktop app
Radicle
Git
Toggle commits in patch revisions
Merged did:key:z6MkkfM3...sVz5 opened 1 year ago

Allows users to toggle the showed diff, between individual commits and the full revision

did:key:z6MkkfM3...sVz5 opened with revision 001ec838 on base 0efb4e09 +76 -11 1 year ago

Allows users to toggle the showed diff, between individual commits and the full revision

did:key:z6MkkfM3...sVz5 pushed revision 2 0c414140 on base 0efb4e09 +84 -12 1 year ago
rudolfs reviewed · 2 comments 1 year ago

I love this, very elegant solution for showing individual commits without needing to go to a different view.

  • it’s weird that the base commit id doesn’t have a hover state. don’t have a good solution for it either.
  • related to this it’s also weird that we now have a global-none class, also not sure how to solve this properly
  • now that the commit selector influences the file section below, it doesn’t make sense that the “Collapse all” button also collapses the commit selector
  • the collapsed/expanded state should probably reset when toggling between commits
  • the hover states that have a background color should have a bit more padding

Screenshot 2025-03-17 at 14.34.40.png Screenshot 2025-03-17 at 14.29.49.png

did:key:z6MkkfM3...sVz5 pushed revision 3 a4747644 on base 2c8b00ca +103 -19 1 year ago

Rebase, extract some functions out of the components and address feedback by rudolfs.

Didn’t tackle the style issues since we need to figure them first out with @daniel

rudolfs pushed revision 4 5324431c on base 6f783193 +103 -19 1 year ago

Rebase

rudolfs accepted 1 year ago
rudolfs merged revision 5324431c at 47ea7d78 1 year ago