Radish alpha
r
rad:z4D5UCArafTzTQpDZNQRuqswh3ury
Radicle desktop app
Radicle
Git
Screenshots get rendered multiple times in patch review teasers
Closed { reason: Other } rudolfs opened 1 year ago

Steps to reproduce:

  • have a patch with a review that has a screenshot
  • click on the patch in the sidebar multiple times
  • the screenshots in the review teaser get rendered multiple times

Expected:

  • reloading the patch shouldn’t duplicate the screenshots in the review teaser

This only seems to happen in review teasers, patch body, comments, replies and issues seem to handle this fine.

Screenshot 2025-03-17 at 14.59.17.png

rudolfs commented 1 year ago

Think this was a problem with reviews not supporting embeds in the first place, so the front-end had the screenshots somewhere cached. We disabled review embeds for now until the protocol supports it here.