Sync
Nov 22
Patch page structure - Click dummy ° Figma
- title is now full width, main content and metadata start below it
- collapsed sidebar shows filters like the expanded sidebar does
- compact issue/patch titles (in the teaser, when a single issue/patch is visible) are all 1 line now to make it easier to read - this is something we discussed regarding the inbox, but I thought it makes sense here too. I’d show the entire title when the issue/patch list is full width.
- revision tab marker doesn’t go full width
- we said to move the Ready to be merged label with the revision instead of the patch (metadata sidebar), but I think that serves basically the same purpose as the Accepted by xy message that is there now. So I’d either leave it in the metadata sidebar or remove it
- we thought earlier that sidebar filters (revision > reviews/discussion/changes) should just scroll to the section, but
- that would work differently than the other filters we use in the sidebar
- we would have to unselect that ‘filter’ once you scroll away which is strange
- i think we can impose focus on the users and say if you want to see the changes you only see the changes - its easy to get back anyway
- added a ‘a revision has been accepted’ marker on the patch list
Inbox - Designs in the same Figma
- repo inbox in popover
- teasers are now all 1 line
- collapse the rest of the changes with avatars
- added a Mark all as read button
- emphasize currently open patch/issue
- breadcrumb-like navigation takes you to all-repo inbox - this i’m not totally happy with yet
Also, I think you’re right sebastinez and clicking a patch should always take you to patch list/patch view instead of a new inbox/patch view:
- you’re most likely going to focus on that repo once you’re interacting with one patch/issue
- you can always press back to go back to the all-repo inbox
- we don’t need to create a new view
### Inbox Aggregation
- Spawn a thread that executes in a specified interval.
- Queries the inbox database for new items.
- If a new inbox row is found and it’s a cob type_id it iterates over the happened operations.
- It weights them according to weights given to each action.
- Creates notification items in the desktop db that are a subset of the rad inbox db rows.
- Either a 1:1 relation between notification and inbox item or worst case many:1
- Each notification item should also have a own read and archived state.
- The remote public key of the inbox db should be aggregated to cobs::Author with their alias.
- When a inbox item is acted upon by e.g. the CLI we need to sync this in the desktop db.
- Also the reverse should happen, if we find that each desktop db notification item of a inbox db row is marked as read, the inbox db row should also be marked as read.
- For cobs and branches we should also group inbox db entries of different remotes into the same desktop db entry.
Questions
- What happens with older notifications of a ref in a given repo? Source. Is it possible to get all notifications of a ref in a given repo instead of only the newest ones? Or does the RefUpdate keep the old head of the branch of older notifications and it updates the new head only?
Repo Home - Figma
- about: description + README
- branches, timeline
- code
- metadata: delegates, default branch, open patches/issues
Show it as one continuous flow like we do for patch/issue, or separate them in tabs
This is probably outdated, closing.