Radish alpha
r
rad:z4D5UCArafTzTQpDZNQRuqswh3ury
Radicle desktop app
Radicle
Git
Reaction emojis with more character pls ๐Ÿ‘พ
Open rudolfs opened 1 year ago blocked

The current set is a bit github boomer emojis. Would be cool to have a bit more character and on brand for radicle. We could also let the user slect any emojis they want and remember their favourites.

๐Ÿค™๐Ÿ™๐Ÿ’ฏ๐Ÿ™‡๐Ÿ‘ฝ๐Ÿ‘พ๐Ÿ™…

z6MkkfM3...sVz5 commented 1 year ago

Let users select the emojis they want would require us to add some library with a emoji selector, so they can select any reaction they want to. (I would prefer to not implement this ourselves) We could also add a configuration option to settings so users could define the reaction they want to use, so it can go a bit faster.

rudolfs commented 1 year ago

Yeah I agree that we should probably use a library for custom emojis. Alternatively we could expose the list of predefined emojis in the settings popover as an input field where the user can just paste in a list of their favourite emojis that will become available as reactions along with the default ones.

But the first ask is to just spice up the current emoji selection. Wonder what @daniel thinks about this?

rudolfs commented 1 year ago

We might also need to adjust things in heartwood, Iโ€™m getting an error when I use emojis that arenโ€™t in our default list (e.g. ๐Ÿซถ, โค๏ธ, etc.):

Editing reactions failed"invalid args `action` for command `edit_issue`: invalid reaction"
z6MkkfM3...sVz5 commented 1 year ago

Just so we donโ€™t loose track, this is blocked currently by the open patch for heartwood here https://app.radicle.xyz/nodes/ash.radicle.garden/rad:z3gqcJUoA1n9HaHKufZs5FCSGazv5/patches/4bbd94f9d3c318a33b5991485a88c2d9703cd0fe

z6MkkfM3...sVz5 commented 11 months ago

So the patch mentioned in comment 062c585 has been merged but we rely on an older commit of the radicle crate. Will tackle this once heartwood 1.2.0 comes out and new crates are published

rudolfs commented 11 months ago

Def not top prio. Just thought it would be nice to have a different set to choose from without even spending time to implement the full emoji picker.