Radish alpha
r
radicle-desktop
Radicle desktop app
Radicle
Git (anonymous pull)
Log in to clone via SSH
Commits ›
Show commit list in review view
Rūdolfs Ošiņš committed 1 year ago
commit 0c1b441ed260ae70fe442cfa4f9fb0ab4025be69
parent d4a2677f573936c3754c4a1f45c61aba45bc91d4
2 files changed +27 -37
modified src/components/Changes.svelte
@@ -17,17 +17,10 @@
    patchId: string;

    revision: Revision;

    rid: string;
- 
    showCommits?: boolean;

    codeComments?: CodeComments;

  }
- 
  const {
- 
    patchId,
- 
    revision,
- 
    rid,
- 
    showCommits = true,
- 
    codeComments,
- 
  }: Props = $props();
+ 
  const { patchId, revision, rid, codeComments }: Props = $props();



  let hideChanges = $state(false);

  let filesExpanded = $state(true);
@@ -118,35 +111,33 @@
</div>



<div class:hide={hideChanges}>
- 
  {#if showCommits}
- 
    {#await loadCommits(rid, revision.base, revision.head) then commits}
- 
      <div style:margin-bottom="1rem">
- 
        <CommitsContainer expanded={filesExpanded}>
- 
          {#snippet leftHeader()}
- 
            <div class="txt-semibold">Commits</div>
- 
          {/snippet}
- 
          {#snippet children()}
- 
            <div style:padding="0 1rem">
- 
              <div
- 
                class="global-flex txt-small"
- 
                style:color="var(--color-foreground-dim)">
- 
                <Icon name="branch" /><Id id={revision.base} variant="commit" />
- 
                <div class="global-counter">base</div>
- 
              </div>
- 
              <div class="commits">
- 
                {#each commits.reverse() as commit}
- 
                  <div class="commit" style:position="relative">
- 
                    <div class="commit-dot"></div>
- 
                    <CobCommitTeaser {commit} />
- 
                  </div>
- 
                {/each}
- 
              </div>
+ 
  {#await loadCommits(rid, revision.base, revision.head) then commits}
+ 
    <div style:margin-bottom="1rem">
+ 
      <CommitsContainer expanded={filesExpanded}>
+ 
        {#snippet leftHeader()}
+ 
          <div class="txt-semibold">Commits</div>
+ 
        {/snippet}
+ 
        {#snippet children()}
+ 
          <div style:padding="0 1rem">
+ 
            <div
+ 
              class="global-flex txt-small"
+ 
              style:color="var(--color-foreground-dim)">
+ 
              <Icon name="branch" /><Id id={revision.base} variant="commit" />
+ 
              <div class="global-counter">base</div>

            </div>
- 
          {/snippet}
- 
        </CommitsContainer>
- 
      </div>
- 
    {/await}
- 
  {/if}
+ 
            <div class="commits">
+ 
              {#each commits.reverse() as commit}
+ 
                <div class="commit" style:position="relative">
+ 
                  <div class="commit-dot"></div>
+ 
                  <CobCommitTeaser {commit} />
+ 
                </div>
+ 
              {/each}
+ 
            </div>
+ 
          </div>
+ 
        {/snippet}
+ 
      </CommitsContainer>
+ 
    </div>
+ 
  {/await}



  {#await loadHighlightedDiff(rid, revision.base, revision.head)}

    <span class="txt-small">Loading…</span>
modified src/components/Review.svelte
@@ -387,7 +387,6 @@
      threads: codeCommentThreads,

    }}

    rid={repo.rid}
- 
    showCommits={false}

    {patchId}

    {revision} />

</div>