The main goal of this patch is to define core Radicle types so that
crates do not have to use radicle as the main dependency, when all
they need are a few core types.
This will eventually result in smaller crates that are scoped to
well-defined concepts, eventually resulting in untangling the
radicle crate, so that it simply re-exports all the smaller crates.
The first two types in this crate are RepoId and NodeId, since
they are ubuiquitous to all other functionality.
The main goal of this patch is to define core Radicle types so that
crates do not have to use radicle as the main dependency, when all
they need are a few core types.
This will eventually result in smaller crates that are scoped to
well-defined concepts, eventually resulting in untangling the
radicle crate, so that it simply re-exports all the smaller crates.
The first two types in this crate are RepoId and NodeId, since
they are ubuiquitous to all other functionality.
Something isn’t quite right. If you look at my CI’s output (https://cci.rad.levitte.org//9bc17919-46e6-4817-8816-f37aa61ccd84.html), there are some errors there, which I’ve corroborated manually on my laptop:
$ cargo test --workspace --no-fail-fast
...
Doc-tests radicle_core
running 2 tests
test crates/radicle-core/src/node.rs - node (line 9) ... FAILED
test crates/radicle-core/src/node.rs - node (line 5) ... FAILED
failures:
---- crates/radicle-core/src/node.rs - node (line 9) stdout ----
error[E0425]: cannot find value `z6MknSLrJoTcukLrE435hVNQT4JUhbvWLX4kUzqkEStBU8Vi` in this scope
--> crates/radicle-core/src/node.rs:10:1
|
3 | z6MknSLrJoTcukLrE435hVNQT4JUhbvWLX4kUzqkEStBU8Vi
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ not found in this scope
error: aborting due to 1 previous error
For more information about this error, try `rustc --explain E0425`.
Couldn't compile the test.
---- crates/radicle-core/src/node.rs - node (line 5) stdout ----
error: expected expression, found keyword `type`
--> crates/radicle-core/src/node.rs:6:45
|
3 | MULTIBASE(base58-btc, MULTICODEC(public-key-type, raw-public-key-bytes))
| ^^^^ expected expression
error[E0425]: cannot find value `base58` in this scope
--> crates/radicle-core/src/node.rs:6:11
|
3 | MULTIBASE(base58-btc, MULTICODEC(public-key-type, raw-public-key-bytes))
| ^^^^^^ not found in this scope
error[E0425]: cannot find value `btc` in this scope
--> crates/radicle-core/src/node.rs:6:18
|
3 | MULTIBASE(base58-btc, MULTICODEC(public-key-type, raw-public-key-bytes))
| ^^^ not found in this scope
error[E0425]: cannot find function, tuple struct or tuple variant `MULTIBASE` in this scope
--> crates/radicle-core/src/node.rs:6:1
|
3 | MULTIBASE(base58-btc, MULTICODEC(public-key-type, raw-public-key-bytes))
| ^^^^^^^^^ not found in this scope
error: aborting due to 4 previous errors
For more information about this error, try `rustc --explain E0425`.
Couldn't compile the test.
failures:
crates/radicle-core/src/node.rs - node (line 5)
crates/radicle-core/src/node.rs - node (line 9)
test result: FAILED. 0 passed; 2 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.05s
error: doctest failed, to rerun pass `-p radicle-core --doc`
...
Review
Accept Review Changes
Minor rewordings of commit messages