Radish alpha
h
rad:z3gqcJUoA1n9HaHKufZs5FCSGazv5
Radicle Heartwood Protocol & Stack
Radicle
Git
cli/patch: Use clap
Merged did:key:z6MkgFq6...nBGz opened 6 months ago

Add patch CLI parsing with clap

did:key:z6MkgFq6...nBGz opened with revision f9f6791c on base b7a7f55e +925 -966 6 months ago

Add patch CLI parsing with clap

did:key:z6MkgFq6...nBGz pushed revision 2 c72c46ee on base d9ae29de +722 -965 6 months ago

Changes:

  • Rebase
did:key:z6MkgFq6...nBGz pushed revision 3 1f367723 on base 63486688 +738 -967 6 months ago

Various fixes

fintohaps pushed revision 4 e3531519 on base 6cfed884 +925 -962 6 months ago

Improve the initial draft

The non-exhaustive list of changes are:

  • Follow the original copy of the rad patch command help
  • Make MessageArgs a re-usable struct that converts to Message
  • Restructure ReviewArgs and remove ReviewActionArgs – the conversion to the review::Operation was incorrect, so this was fixed. While I was at it, I also improved the grouping of those parameters, using some clap tricks.
  • Ensured the diff of commands::patch is easier to read
  • Added LabelArgs and AssignArgs so that we can mark them as required
  • Hide the [no-]announce flags, and expose them through should_announce
  • Removed some unused fields
fintohaps pushed revision 5 c265e231 on base 6cfed884 +934 -962 6 months ago

Changes:

  • Resolve TODOs
  • Fixes to visibility
lorenz pushed revision 6 b9e58185 on base 9bcdd353 +941 -962 6 months ago

Review and rebase

fintohaps pushed revision 7 a429e89b on base 9bcdd353 +941 -962 6 months ago

Changes:

  • Change formatting of (default: cwd) to [default: cwd]
  • pub(super) for ReviewOptions
fintohaps pushed revision 8 31e219d8 on base e404f103 +941 -962 6 months ago

Rebase

lorenz merged revision 31e219d8 at d1e19a87 6 months ago