Radish alpha
h
rad:z3gqcJUoA1n9HaHKufZs5FCSGazv5
Radicle Heartwood Protocol & Stack
Radicle
Git
cli: Detect key mismatch
Merged lorenz opened 7 months ago

When run with a secret and public key that do not cryptographically match, fn radicle_cli::terminal::io::signer would prompt the user for a password to unlock the secret key, and then carry on with a mismatching key pair.

Fix this by verifying that the keys match in MemorySigner::load and only swallow errors initializing the signer in cases where prompting for a password makes sense. It does not make sense in the case of mismatched keys.

lorenz opened with revision f9df8693 on base ed8b0860 +78 -20 7 months ago

When run with a secret and public key that do not cryptographically match, fn radicle_cli::terminal::io::signer would prompt the user for a password to unlock the secret key, and then carry on with a mismatching key pair.

Fix this by verifying that the keys match in MemorySigner::load and only swallow errors initializing the signer in cases where prompting for a password makes sense. It does not make sense in the case of mismatched keys.

fintohaps merged revision f9df8693 at fafb3493 7 months ago