Radish alpha
h
rad:z3gqcJUoA1n9HaHKufZs5FCSGazv5
Radicle Heartwood Protocol & Stack
Radicle
Git
radicle/node/db: Fix type of IPv6 addresses
Merged lorenz opened 1 month ago

Due to a bug introduced in df8e4e6c88a8bfb6c1ec6b07dcda64093b477cbe, IPv6 addresses in the configuration file might have ended up in the database tagged with type = "dns", which is incorrect. The bug was fixed in a2e72b48e79d090d33f6c13c485239947de0522e.

However, Radicle 1.7.0 was released in between those two versions, so a this migration to repair the entries is added.

lorenz opened with revision f9738adc on base d01ff2e7 +11 -0 1 month ago

Due to a bug introduced in df8e4e6c88a8bfb6c1ec6b07dcda64093b477cbe, IPv6 addresses in the configuration file might have ended up in the database tagged with type = "dns", which is incorrect. The bug was fixed in a2e72b48e79d090d33f6c13c485239947de0522e.

However, Radicle 1.7.0 was released in between those two versions, so a this migration to repair the entries is added.

lorenz pushed revision 2 7568c9a7 on base d01ff2e7 +11 -0 1 month ago

Fix whitespace

lorenz pushed revision 3 45089751 on base d01ff2e7 +11 -0 1 month ago

Use single quotes for values.

lorenz pushed revision 4 7d5652b9 on base d01ff2e7 +12 -0 1 month ago

Consider uniqueness constraints

lorenz pushed revision 5 5cdb4dd5 on base a80bb031 +12 -0 1 month ago

Rebase

fintohaps pushed revision 6 a1e04118 on base a80bb031 +230 -0 1 month ago

REVIEW

Add the migration to the MIGRATIONS.

Add the tests under a test::migration_8 module. This required adding some test setup, mainly adding a Database::memory_up_to_migration constructor that is only available to test code.

lorenz pushed revision 7 825145f8 on base a80bb031 +230 -0 1 month ago

Squash in review.

lorenz pushed revision 8 ebbd7b87 on base a6a3716f +0 -0 1 month ago

Rebase

lorenz merged revision ebbd7b87 at a6a3716f 1 month ago