These are misc patches I found while browsing the source code. The individual patches are not related.

Found some more things… Yes, I am bored and don’t know what to do with my time ;-)

Did you run tests here?

I got a failure for ‘git_push_converge’:

--- Expected
++++ actual:   stdout
   1    1 | Fetching rad:z42hL2jL4XNk6K8oHQaSWfMgCL7ji from the network, found 2 potential seed(s).
   2    2 | ✓ Target met: 2 seed(s)
        3 + 🌱 Fetched from z6MknSLrJoTcukLrE435hVNQT4JUhbvWLX4kUzqkEStBU8Vi
   3    4 | 🌱 Fetched from z6Mkux1aUQD2voWWukVb5nNUR7thrHveQG4pDQua8nVhib7Z
   4      - 🌱 Fetched from z6MknSLrJoTcukLrE435hVNQT4JUhbvWLX4kUzqkEStBU8Vi

And another related one that looks similar. Maybe your changes changed the ordering of something? Is that intended? If so, please also change the test(s). Thanks.

I did not know that rejection would remove this patch from the listing in Radicle Explorer. I cannot remove my review either. So I accept. The changes look good in general but tests should be run and might require minor changes. Sorry about the chaos.

My feeling is that the error is due to the change in eb18819b35a058730b88fb4d3e8b3e76920d3969, where the sorting was removed. However, why that is I’m not sure and I’m entirely confused as to why

Remove offending commit (eb18819 in revision e3c08c8e), rebase.