Radish alpha
h
rad:z3gqcJUoA1n9HaHKufZs5FCSGazv5
Radicle Heartwood Protocol & Stack
Radicle
Git
build: Switch to build args over env vars in dockerfile
Merged yorgos-laptop opened 1 year ago

--env is a podman-specific feature. While it is clear that podman is a requirement here, switching these to build arguments better expresses intent.

These values are meant to be configurable at build time, which is exactly what build arguments are for, while environment variables are meant to persist in the image built.

Additionally, this removes a couple of unused env vars.

yorgos-laptop opened with revision cdaefea5 on base 0834e0fc +11 -6 1 year ago

--env is a podman-specific feature. While it is clear that podman is a requirement here, switching these to build arguments better expresses intent.

These values are meant to be configurable at build time, which is exactly what build arguments are for, while environment variables are meant to persist in the image built.

Additionally, this removes a couple of unused env vars.

yorgos-laptop pushed revision 2 a6e47189 on base dff6df10 +11 -6 1 year ago

rebased on master

yorgos-laptop pushed revision 3 9bf82bc5 on base a6e33ec1 +11 -6 1 year ago

Rebased on master

yorgos-laptop pushed revision 4 f242d6ab on base a6e33ec1 +12 -6 1 year ago

Brought back SOURCE_DATE_EPOCH which was mistakenly removed.

did:key:z6MksFqX...wzpT pushed revision 5 ceabf7f5 on base a6e33ec1 +10 -7 1 year ago

Simplifications.

yorgos-laptop pushed revision 6 89f7599b on base a6e33ec1 +12 -7 1 year ago

Added back the necessary ARGs in the second build stage.

according to docs they need to be defined in every build stage: https://docs.docker.com/reference/dockerfile/#arg

did:key:z6MksFqX...wzpT pushed revision 7 23c4566f on base ce99f7e7 +14 -7 1 year ago

Rebase, fix commit message.

did:key:z6MksFqX...wzpT merged revision 23c4566f at 6966c971 1 year ago