Radish alpha
h
rad:z3gqcJUoA1n9HaHKufZs5FCSGazv5
Radicle Heartwood Protocol & Stack
Radicle
Git
radicle/profile: Control socket path for Windows
Merged lorenz opened 8 months ago

The winpipe crate which is our current best bet for support on Windows requires that named pipes are at the magical location \\.pipe\.

Provide a default on Windows that matches this, and use our freshly assigned IANA service name for it.

This is a breaking change, as we remove a pub const, it should be reasonably easy to fix by dependents, and probably it was a mistake to make the default pub const as dependents should call Home::socket anyway.

lorenz opened with revision c7498dcd on base a670b6e6 +13 -3 8 months ago

The winpipe crate which is our current best bet for support on Windows requires that named pipes are at the magical location \\.pipe\.

Provide a default on Windows that matches this, and use our freshly assigned IANA service name for it.

This is a breaking change, as we remove a pub const, it should be reasonably easy to fix by dependents, and probably it was a mistake to make the default pub const as dependents should call Home::socket anyway.

lorenz pushed revision 2 134e2023 on base a670b6e6 +13 -3 8 months ago

Review

lorenz pushed revision 3 f601a168 on base a670b6e6 +37 -3 8 months ago

Review

lorenz pushed revision 4 92d68d4e on base a670b6e6 +50 -5 8 months ago

Review

fintohaps pushed revision 5 ed43f925 on base fd34b680 +50 -5 8 months ago

Rebased

fintohaps merged revision ed43f925 at ce11f03f 8 months ago