Radish alpha
h
rad:z3gqcJUoA1n9HaHKufZs5FCSGazv5
Radicle Heartwood Protocol & Stack
Radicle
Git
cli/sync: migrate to clap
Merged fintohaps opened 6 months ago

Due to the idiosyncracies of this command there are a few things to note about this migration.

The rad sync command acts as a default subcommand in itself, in that it has options that do not apply to its subcommand, rad sync status. This means that the options will print with rad sync --help, but they will not print with rad sync status.

The --inventory flag is not compatible with any of the other flags and options, thus they are all marked with conflicts_with. This cannot be done for a positional argument, so clap will “helpfully” print out the usage, for example, as:

error: the argument '--inventory' cannot be used with '--fetch'

Usage: rad sync --inventory [RID]

For more information, try '--help'.

Which is incorrect, since RID is ignored. This is explained in the --help documentation for --inventory.

fintohaps opened with revision bc69c2c2 on base 6cfed884 +311 -296 6 months ago

Due to the idiosyncracies of this command there are a few things to note about this migration.

The rad sync command acts as a default subcommand in itself, in that it has options that do not apply to its subcommand, rad sync status. This means that the options will print with rad sync --help, but they will not print with rad sync status.

The --inventory flag is not compatible with any of the other flags and options, thus they are all marked with conflicts_with. This cannot be done for a positional argument, so clap will “helpfully” print out the usage, for example, as:

error: the argument '--inventory' cannot be used with '--fetch'

Usage: rad sync --inventory [RID]

For more information, try '--help'.

Which is incorrect, since RID is ignored. This is explained in the --help documentation for --inventory.

lorenz pushed revision 2 b302ab12 on base 990e22ac +311 -297 6 months ago

Review

fintohaps pushed revision 3 5256623d on base e404f103 +311 -296 6 months ago

Rebase

lorenz pushed revision 4 799b11fd on base d1e19a87 +313 -297 6 months ago

Squash most of my review from revision b302ab1226b82e0e3b52ea5ffcc290ee9220640b and rebase.

lorenz merged revision 799b11fd at 3c895250 6 months ago