Radish alpha
h
rad:z3gqcJUoA1n9HaHKufZs5FCSGazv5
Radicle Heartwood Protocol & Stack
Radicle
Git
radicle-cli: Build on Windows
Merged lorenz opened 9 months ago

This patch contains a number of changes, with the main goal of getting radicle-cli to build on Windows.

In order to achieve this, I removed some features:

  1. The spinner in radicle-term does not react to signals on Windows, of course it still reacts to signals on Unix-like platforms.
  2. In radicle file limits are not set on Windows, the implementation always errors. Of course, file limits are still set on Unix-like platforms.

One feature was added: radicle and radicle-ssh now support not only Unix Domain Socket on Unix-like platforms but also Named Pipes on Windows, via the winpipe crate. The (useless?) implementation for connecting to SSH agents via TCP streams was removed.

Some behaviour was changed in radicle-term so that it does not depend on libc and raw file descriptors (which are only available on Unix-like platforms).

lorenz opened with revision af3292c4 on base fe6a11d0 +267 -59 9 months ago

This patch contains a number of changes, with the main goal of getting radicle-cli to build on Windows.

In order to achieve this, I removed some features:

  1. The spinner in radicle-term does not react to signals on Windows, of course it still reacts to signals on Unix-like platforms.
  2. In radicle file limits are not set on Windows, the implementation always errors. Of course, file limits are still set on Unix-like platforms.

One feature was added: radicle and radicle-ssh now support not only Unix Domain Socket on Unix-like platforms but also Named Pipes on Windows, via the winpipe crate. The (useless?) implementation for connecting to SSH agents via TCP streams was removed.

Some behaviour was changed in radicle-term so that it does not depend on libc and raw file descriptors (which are only available on Unix-like platforms).

lorenz pushed revision 2 7f73d22d on base 010d5134 +434 -416 9 months ago

Rebase

lorenz pushed revision 3 aa872fea on base 010d5134 +444 -416 9 months ago

Improve SSH encoding

lorenz pushed revision 4 982bd2f7 on base 010d5134 +447 -416 9 months ago

Refactor home detection to not require any mutable variables and limit scope of variables.

fintohaps pushed revision 5 35317900 on base 010d5134 +461 -416 9 months ago

Changes

ssh: provide path on connect error

Provide the path that is being used for connecting to the SSH agent, when an I/O error occurs.


term: provide default HELP message

Provide a default message that informs the user of the (e), (enter), and (esc) functionality.

Unfortunately, it is not possible to provide any message that is better customised to each case, due to inquire requiring a 'a lifetime on all its inputs – this rules out providing any kind of String input.

The first paramter of Editor::new can already be used to provide more contextual information. The second parameter is left configurable, but for now Editor::HELP is used everywhere.

lorenz pushed revision 6 51c3735c on base 37ea8176 +462 -417 9 months ago

Rebase

lorenz merged revision 51c3735c at 2a47bc0c 9 months ago