Use new function to add commands for modifying configuration values.
Note that the changes will affect the configuration file, but not the running instances. For changes to be reflected in the running instances the node would need to be restarted.
Use new function to add commands for modifying configuration values.
Note that the changes will affect the configuration file, but not the running instances. For changes to be reflected in the running instances the node would need to be restarted.
Add a function to programmatically modify the configuration
Note that the changes will affect the configuration file, but not the running instances. For changes to be reflected in the running instances the node would need to be restarted. Add commands for modifying configuration values.
Add programmatic config changes
Ensure the config changes don’t overwrite existing additional values.
Add a function to programmatically modify the configuration
Note that the changes will affect the configuration file, but not the running instances. For changes to be reflected in the running instances the node would need to be restarted.
Use .iter() instead of .into_iter() to avoid cloning.
Remove Action design and offer methods directly.
Move Validation to write method of TempConfig.
Use functions directly in cli.
WIP: code review
- Moved config related code into a
configmodule so that it’s easier to work with - Created a
ModifyErrorenum for handling the modification errors - Some wording changes on the error messages
- There was a bug where
rad config addof a non-existent path would not create an array. This was fixed and a test case was added - Changed
iterto return the trait object instead - Changed
lastto return a reference - Use
split_lastto construct theConfigPath::parent - Left a TODO since the API is technically unsafe since someone can construct a
ConfigValue::Floatwith NaN if they construct it directly
REVIEW
- Use
term::args::stringto parse key/value inputs - No need to print anything when deleting a key
- Print
nullvalue - Remove
lastandparentmethods in favour ofsplit_lastmethod - General cleanup and formatting of docs
- Leave FIXME for corner case of
ConfigPaththat may want to refer to a key with a.in it
A few small improvements and changes in the API.
delete -> unset
add -> push
Fix trailing line.