Radish alpha
h
rad:z3gqcJUoA1n9HaHKufZs5FCSGazv5
Radicle Heartwood Protocol & Stack
Radicle
Git
radicle: improve reviews
Merged fintohaps opened 10 months ago

The Review::summary was limited in behaviour, since it was only an Option<String>.

The field is now changed to NonEmpty<Edit> so that it can enable an edit history, as well as being able to supply embeds as part of the text.

Reactions are also introduced to Review and, necessarily, introducing an Action::ReviewReact.

Note that some machinery was added under actions and encoding to enable backwards-compatibility. For actions, a new ReviewEdit is introduced to keep track of the different versions of editing actions – supporting the old actions while also introducing the new variant. For encoding, the machinery exploits the fact that an Option<String> can be converted into a NonEmpty<Edit> given that an ActorId and Timestamp are available, and that None can be converted into an empty string. The struct patch::Review now deserializes via this encoding::review::Review type and, importantly, preserves backwards-compatibility.

fintohaps opened with revision aa9cee5a on base 78ba263d +573 -45 10 months ago

The Review::summary was limited in behaviour, since it was only an Option<String>.

The field is now changed to NonEmpty<Edit> so that it can enable an edit history, as well as being able to supply embeds as part of the text.

Reactions are also introduced to Review and, necessarily, introducing an Action::ReviewReact.

Note that some machinery was added under actions and encoding to enable backwards-compatibility. For actions, a new ReviewEdit is introduced to keep track of the different versions of editing actions – supporting the old actions while also introducing the new variant. For encoding, the machinery exploits the fact that an Option<String> can be converted into a NonEmpty<Edit> given that an ActorId and Timestamp are available, and that None can be converted into an empty string. The struct patch::Review now deserializes via this encoding::review::Review type and, importantly, preserves backwards-compatibility.

did:key:z6MkgFq6...nBGz pushed revision 2 0b5e8ce5 on base c30298fb +573 -45 9 months ago

Rebase and clear up test.

did:key:z6MkgFq6...nBGz merged revision 0b5e8ce5 at 34939253 9 months ago