Radish alpha
h
rad:z3gqcJUoA1n9HaHKufZs5FCSGazv5
Radicle Heartwood Protocol & Stack
Radicle
Git
Revisit `radicle::git::raw`
Merged lorenz opened 6 months ago

Capture all git2 re-exports

A refactoring internal to the radicle crate, with the goal of making dependency on git2 clearer and more controlled. radicle::git::raw is changed from a complete re-export of git2 to a module that selectively re-exports (many) members of git2.

In the future, no more use git2::… statements should be added outside of crates/radicle/src/git/raw.rs. This is in an effort to decrease dependence on git2 in the future.

Introduce trait ErrorExt

This extension trait is more ergonomic than what radicle-git-ext provides.

lorenz opened with revision a1b9d9c9 on base ac572e64 +342 -236 6 months ago

Capture all git2 re-exports

A refactoring internal to the radicle crate, with the goal of making dependency on git2 clearer and more controlled. radicle::git::raw is changed from a complete re-export of git2 to a module that selectively re-exports (many) members of git2.

In the future, no more use git2::… statements should be added outside of crates/radicle/src/git/raw.rs. This is in an effort to decrease dependence on git2 in the future.

Introduce trait ErrorExt

This extension trait is more ergonomic than what radicle-git-ext provides.

lorenz pushed revision 2 d09327bc on base ac572e64 +342 -236 6 months ago

Improve commit message.

fintohaps pushed revision 3 8755d341 on base ac572e64 +343 -238 6 months ago

REVIEW

I’ve moved the ErrorExt introduction from the first commit to the second, as the second commit said it is being introduced there. This was safe, since it wasn’t being used in the first commit.

I added a review commit to fix up some small sections of code.

lorenz pushed revision 4 cbdfd36d on base 63305904 +374 -248 6 months ago

Rebase

fintohaps merged revision cbdfd36d at ea562215 6 months ago