Radish alpha
h
rad:z3gqcJUoA1n9HaHKufZs5FCSGazv5
Radicle Heartwood Protocol & Stack
Radicle
Git
cli/id: Use clap
Merged did:key:z6MkgFq6...nBGz opened 6 months ago

This implementation works around the fact that clap does currently not support value parsers for a series of values, so representing --payload as a Vec<Payload> does not work.

Instead, we parse eveything into a Vec<String> and do the validation on the application side.

Using value parsers for a series of values will probably be supported in clap v5, though.

did:key:z6MkgFq6...nBGz opened with revision 9e45558d on base 3e98589a +276 -252 6 months ago

This implementation works around the fact that clap does currently not support value parsers for a series of values, so representing --payload as a Vec<Payload> does not work.

Instead, we parse eveything into a Vec<String> and do the validation on the application side.

Using value parsers for a series of values will probably be supported in clap v5, though.

did:key:z6MkgFq6...nBGz pushed revision 2 5743b400 on base efe10f95 +276 -252 6 months ago
  • Rebase
fintohaps pushed revision 3 4afef0bc on base efe10f95 +280 -282 6 months ago

REVIEW

did:key:z6MkgFq6...nBGz pushed revision 4 8391c927 on base dfd35480 +356 -282 6 months ago

Changes:

  • Return impl Iterator from payload parsing function
  • Assert value number in payload parsing function
  • Add unit tests
fintohaps pushed revision 5 c2b443e1 on base dfd35480 +373 -282 6 months ago

REVIEW

did:key:z6MkgFq6...nBGz pushed revision 6 2f9c6421 on base dfd35480 +373 -282 6 months ago
  • Squash review commits
did:key:z6MkgFq6...nBGz pushed revision 7 8904aec7 on base 384c5064 +373 -282 6 months ago
  • Rebase
lorenz pushed revision 8 9549a776 on base 384c5064 +412 -309 6 months ago

Review

did:key:z6MkgFq6...nBGz pushed revision 9 a67b55d8 on base 384c5064 +425 -309 6 months ago

Changes:

  • Use REVISION_ID and fix a missing new line
fintohaps pushed revision 10 d10bf70a on base 384c5064 +411 -309 6 months ago

Changes:

  • Squashed lorenz’s changes
  • Removed errant whitespace
  • Renamed all accounts of REVISON-ID to REVISION_ID
fintohaps pushed revision 11 2159229e on base 384c5064 +414 -309 6 months ago

REVIEW: make the panic message even nicer

lorenz pushed revision 12 a64f3885 on base ec1d7543 +411 -309 6 months ago

Rebase

lorenz merged revision a64f3885 at 63486688 6 months ago