Radish alpha
h
rad:z3gqcJUoA1n9HaHKufZs5FCSGazv5
Radicle Heartwood Protocol & Stack
Radicle
Git
cli: Migrate `rad issue` to `clap`
Merged did:key:z6MkgFq6...nBGz opened 7 months ago

This is a split-off of rad patch show 0866819, that only migrates rad issue.

did:key:z6MkgFq6...nBGz opened with revision 976756d8 on base 646d4360 +895 -392 7 months ago

This is a split-off of rad patch show 0866819, that only migrates rad issue.

did:key:z6MkgFq6...nBGz pushed revision 2 fddbeb73 on base 8c9966b9 +618 -600 7 months ago

Migrate rad issue only, remove everything auto-completion and improve help output.

did:key:z6MkgFq6...nBGz pushed revision 3 222584aa on base 7d1db6a0 +634 -600 7 months ago

Disallow --reply-to together with --edit in rad issue comment.

did:key:z6MkgFq6...nBGz pushed revision 4 00a0fef2 on base 646d4360 +585 -539 7 months ago
  • reword initial commit message
  • remove --version from subcommands
  • bring back old (incorrect) announcing behaviour for rad issue comment --edit
did:key:z6MkgFq6...nBGz pushed revision 5 98f8060b on base 646d4360 +582 -539 7 months ago

Improve help output and bits of the code

fintohaps pushed revision 6 98245cf6 on base 646d4360 +582 -539 7 months ago

cli/issue: reword argument documentation

fintohaps pushed revision 7 cc985706 on base 646d4360 +865 -678 7 months ago

Further refactoring

These changes refactor a couple of things:

  • First, reintroduces --announce being a flag that is allowed to be passed to the command
  • Refactor the mutual exclusivity of the Comment command into another enum that captures all these cases. This waterfalled into further refactoring of the command handling.
did:key:z6MkgFq6...nBGz pushed revision 8 de518b49 on base 646d4360 +851 -678 7 months ago
  • remove --announce again
  • fix parsing error for issue list --assigned
  • fix default filter for issue list
  • add new CLI test example examples/rad-issue-list.md
fintohaps pushed revision 9 aad491c3 on base 646d4360 +850 -678 7 months ago

Changes:

  • Remove commented out code
did:key:z6MkgFq6...nBGz pushed revision 10 2022ebd5 on base 646d4360 +852 -678 7 months ago

Add changelog entry

lorenz pushed revision 11 2bb2d966 on base ed8b0860 +853 -678 7 months ago
  1. Rebase
  2. Order dependencies in crates/radicle-cli/Cargo.toml alphabetically.
  3. Remove commented code.
  4. Fix typos.
  5. Fix changelog (line was added to changelog for previous release).
lorenz pushed revision 12 1e5d195f on base ed8b0860 +962 -705 7 months ago
  1. Review.
  2. Fix regression of rad issue vanishing from rad -h
did:key:z6MkgFq6...nBGz pushed revision 13 f1823b2e on base ed8b0860 +961 -705 7 months ago

Squash review commits and improve help colors.

did:key:z6MkgFq6...nBGz pushed revision 14 5215b225 on base ed8b0860 +989 -705 7 months ago
  • Fix list state filtering (e.g. rad issue list --solved was broken)
  • Allow list argsuments for empty subcommand

Note: currently the list arguments are included in the main help, which is not desired. It could be worth exploring if we can make the subcommand required, and handle the list args with some custom on parsing errors for empty subcommands.

did:key:z6MkgFq6...nBGz pushed revision 15 acbb7324 on base ed8b0860 +1026 -705 7 months ago

Allow list arguments for empty subcommand, but do not show them in the main help.

lorenz pushed revision 16 99f0e27a on base ed8b0860 +1054 -705 7 months ago

Review

lorenz pushed revision 17 46491c10 on base ed8b0860 +1051 -705 7 months ago
lorenz pushed revision 18 fee2cfdd on base ed8b0860 +1052 -705 7 months ago

Review

did:key:z6MkgFq6...nBGz pushed revision 19 a1a9bfb7 on base 22720e71 +1052 -705 7 months ago

Rebase and squash.

lorenz pushed revision 20 6a7af4d9 on base 22720e71 +1040 -707 7 months ago

Review

lorenz pushed revision 21 9e415fed on base 22720e71 +1040 -707 7 months ago

Squash

lorenz merged revision 9e415fed at c7bff284 7 months ago