Radish alpha
h
rad:z3gqcJUoA1n9HaHKufZs5FCSGazv5
Radicle Heartwood Protocol & Stack
Radicle
Git
crypto: shared agent stream
Merged fintohaps opened 1 year ago

The Mutex within AgentSigner did not seem to make sense. The Mutex could never be shared, since the structs could never be cloned.

It would make more sense to have an Arc<Mutex<AgentClient<Stream>>> within Agent, which could then be shared and cloned when constructing the AgentSigner.

fintohaps opened with revision 8c41872d on base ee0d19f2 +30 -23 1 year ago

The Mutex within AgentSigner did not seem to make sense. The Mutex could never be shared, since the structs could never be cloned.

It would make more sense to have an Arc<Mutex<AgentClient<Stream>>> within Agent, which could then be shared and cloned when constructing the AgentSigner.

lorenz pushed revision 2 db31adc0 on base ee0d19f2 +24 -21 1 year ago

Here’s a version that uses RefCell instead of Mutex. This required dropping Sync from Signer (which would indeed require Mutex).

did:key:z6MksFqX...wzpT pushed revision 3 fbfed720 on base 62d000f7 +24 -21 1 year ago

Rebase.

did:key:z6MksFqX...wzpT merged revision fbfed720 at 3b5fac17 1 year ago