Radish alpha
h
rad:z3gqcJUoA1n9HaHKufZs5FCSGazv5
Radicle Heartwood Protocol & Stack
Radicle
Git
node/reactor: Correctly handle error events
Merged lorenz opened 6 months ago

fn handle_events would panic, if there were multiple events for one token, and the first one that happened to be handled was an error. Indeed it is concerning if a token is encountered that was never registered before. However, tokens that were just deregistered must be tracked.

Using Vec here seems a bit costly, in the future, smallvec::SmallVec could be considered.

The “unregister” methods are renamed to “deregister” to better line up with mio vocabulary.

Log stamtements that helped analysis of the panic that occurred here is overhauled and improved, requiring a Debug bound on types that obviously implement it.

lorenz opened with revision 80ae361a on base 384c5064 +53 -40 6 months ago

fn handle_events would panic, if there were multiple events for one token, and the first one that happened to be handled was an error. Indeed it is concerning if a token is encountered that was never registered before. However, tokens that were just deregistered must be tracked.

Using Vec here seems a bit costly, in the future, smallvec::SmallVec could be considered.

The “unregister” methods are renamed to “deregister” to better line up with mio vocabulary.

Log stamtements that helped analysis of the panic that occurred here is overhauled and improved, requiring a Debug bound on types that obviously implement it.

lorenz pushed revision 2 5756a29e on base 384c5064 +53 -40 6 months ago

Fix errors in commit message

lorenz pushed revision 3 98c2bed3 on base 532e5a0d +53 -40 6 months ago

Rebase

fintohaps pushed revision 4 111ec202 on base 384c5064 +57 -40 6 months ago

REVIEW

lorenz pushed revision 5 48447f14 on base 384c5064 +57 -40 6 months ago

Squash in review

fintohaps pushed revision 6 3bb9b894 on base 72cf3d19 +57 -40 6 months ago

Rebase

fintohaps merged revision 3bb9b894 at 0b342485 6 months ago