Canonical Symbolic References — heartwood

heartwood

rad:z3gqcJUoA1n9HaHKufZs5FCSGazv5

Radicle Heartwood Protocol & Stack

Canonical Symbolic References

Open lorenz opened 7 months ago

Extend the payload xyz.radicle.crefs to additionally support creating symbolic references via the member “symbolic”.

Activity Changes +0 -0

lorenz opened with revision 63b4e1d9 on base 86472fdc +302 -143 7 months ago

Extend the payload xyz.radicle.crefs to additionally support creating symbolic references via the member “symbolic”.

lorenz pushed revision 2 a8f45476 on base 86472fdc +475 -179 7 months ago

First working revision.

fintohaps pushed revision 3 4728a533 on base 86472fdc +488 -183 7 months ago

REVIEW

Super nice set of changes, and seems to fit so nicely into the canonical reference system!

Appreciate the type safety too :)

Left some bits of feedback, but all-in-all I’m very happy with these changes.

lorenz pushed revision 4 61f41e3e on base 86472fdc +476 -185 7 months ago

Work in Fintan’s review.

fintohaps pushed revision 5 4f8b7202 on base 7b00bf2e +476 -185 7 months ago

Rebase

lorenz pushed revision 6 e4e142e1 on base e70850cb +1121 -405 7 months ago

Handle interactions between rules and symrefs, and cyclic symrefs.

fintohaps pushed revision 7 6a1155bc on base e70850cb +1125 -405 7 months ago

REVIEW

See commits for review suggestions.

Looking really good and clean still!

lorenz pushed revision 8 52de3142 on base e70850cb +1128 -405 7 months ago

Squash in Fintan’s review, rename tests as mentioned on Zulip, improve docs on Doc::canonical_refs.

lorenz pushed revision 9 d76a072f on base ed8b0860 +1128 -405 7 months ago

Rebase

lorenz pushed revision 10 17797c55 on base 4787b53b +1132 -405 7 months ago

Rebase

lorenz pushed revision 11 9956ae65 on base ee49e287 +1132 -405 7 months ago

Rebase

lorenz pushed revision 12 785d6bf2 on base c06b00e3 +1135 -402 2 months ago

Push broken rebase. Will fix in future revision.

lorenz pushed revision 13 80f4aaec on base d9915d27 +1134 -411 1 month ago

Rebase

lorenz pushed revision 14 9336db89 on base 80c1bba7 +1008 -115 20 days ago

Fixes, stricter validation.

lorenz pushed revision 15 84b9f1f4 on base 547a7537 +1269 -116 14 days ago

Rebase and add a CLI test.

fintohaps pushed revision 16 e7649fca on base 547a7537 +1300 -125 14 days ago

REVIEW

ade pushed revision 17 b1884c93 on base 547a7537 +1269 -116 13 days ago

REVIEW: Tidy line endings and drop superfluous ‘default’

REVIEW: dropped ‘and’

fintohaps pushed revision 18 9ae34251 on base 547a7537 +1661 -125 13 days ago

REVIEW

Further improve the API so that callers do not need to think about RefString vs Qualified.