Radish alpha
h
rad:z3gqcJUoA1n9HaHKufZs5FCSGazv5
Radicle Heartwood Protocol & Stack
Radicle
Git
node: Use Mio
Merged did:key:z6MkjE4x...MoTo opened 8 months ago

The dependencies netservices, io-reactor and popol served us well, however they do not support Windows and are not actively maintained.

This change removes the aforementioned dependencies (and libc along with them). It reuses the integration with cyphernet from netservices for Noise and SOCKS.

The new module reactor is a rewrite of io-reactor on top of Mio.

Note that no tests were changed.

(This message was written with Radicle on Windows, running on top of this patch.)

did:key:z6MkjE4x...MoTo opened with revision 5ea90b97 on base a4d83ec8 +2042 -307 8 months ago

The dependencies netservices, io-reactor and popol served us well, however they do not support Windows and are not actively maintained.

This change removes the aforementioned dependencies (and libc along with them). It reuses the integration with cyphernet from netservices for Noise and SOCKS.

The new module reactor is a rewrite of io-reactor on top of Mio.

Note that no tests were changed.

(This message was written with Radicle on Windows, running on top of this patch.)

lorenz pushed revision 2 ce806a09 on base a4d83ec8 +1856 -307 8 months ago

More madness.

lorenz pushed revision 3 fb14691f on base df787836 +1856 -307 7 months ago

Rebase

lorenz pushed revision 4 a45e6be0 on base dbdef0d8 +1804 -314 6 months ago

Rebase on new temporary repository implementation

lorenz pushed revision 5 a6d08805 on base 5cd016b5 +1804 -314 6 months ago

Unstack from repository locking.

did:key:z6MkjE4x...MoTo commented on revision 4 6 months ago

Hi from Windows at this revision!

lorenz pushed revision 6 0d911013 on base ed5a68c1 +1806 -315 6 months ago

Rebase

fintohaps pushed revision 7 e0f5a9b6 on base a4d83ec8 +2045 -308 6 months ago

REVIEW: typo fixes on docs

REVIEW: use matches! over [].contains

REVIEW: fix typo ‘fulled’ -> ‘full’

REVIEW: simplify Listener::bind docs

As far as I could tell, we can only bind to one socket address, and there does not seem to be any context – perhaps removed from the previous implementation?

REVIEW: typo ‘not’ -> ‘note’

REVIEW

Just some minor stuff going through the docs and code.

As much as I can understand, it looks good to me. I still need to take it for a spin.

fintohaps pushed revision 8 42d3bff6 on base ed5a68c1 +1808 -318 6 months ago

Changes:

  • Rebase review commits, and adapt them
  • Remove dead code
lorenz pushed revision 9 9c312eb1 on base 3992d519 +1808 -318 6 months ago

Squash in Fintan’s review and rebase.

fintohaps pushed revision 10 c68f583a on base ac572e64 +1808 -318 6 months ago

Rebase

fintohaps pushed revision 11 fb8daf89 on base b25d80d2 +1808 -318 6 months ago

Rebase

fintohaps merged revision fb8daf89 at 63305904 6 months ago