Radish alpha
h
rad:z3gqcJUoA1n9HaHKufZs5FCSGazv5
Radicle Heartwood Protocol & Stack
Radicle
Git
node: use 300s as default upload-pack timeout
Archived gy@morty opened 1 year ago

While working with larger repositories (.git/ folder is 778 MiB in my case), I find my public node frequently emits warnings like

WARN  worker   Read channel timed out for upload-pack rad:<rid>

I’d like to suggest to make the default fetch timeout longer to be 300s (5 minutes), which is more balanced than the previous 1 hour or 3 seconds timeout.

In the future it might also be desirable to allow configurable fetch timeouts, but this patch does not address this.

Signed-off-by: Gaoyang Zhang gy@blurgy.xyz

gy@morty opened with revision 5afd1712 on base 034eb418 +4 -18 1 year ago

While working with larger repositories (.git/ folder is 778 MiB in my case), I find my public node frequently emits warnings like

WARN  worker   Read channel timed out for upload-pack rad:<rid>

I’d like to suggest to make the default fetch timeout longer to be 300s (5 minutes), which is more balanced than the previous 1 hour or 3 seconds timeout.

In the future it might also be desirable to allow configurable fetch timeouts, but this patch does not address this.

Signed-off-by: Gaoyang Zhang gy@blurgy.xyz

gy@morty pushed revision 2 2d40dda8 on base 034eb418 +2 -2 1 year ago
fintohaps commented on revision 2 1 year ago

Thanks for the patch, and sorry for the VERY delayed reply.

We went back and forth on this timeout value for a while originally. After getting a chance to actually investigate the issue there are now a series of patches that will fix this:

Once these are merged, this timeout issue will go away – we’ve tested it on repositories up to 8GB in size.

So, all this said, I’m going to archive your patch in favour of the above :)