In issue
29c6c6fc8171287faa0079798ba2d6e3e7fd86f3
was noted that it would be nice to use value parsers for the timeouts in the CLI.
This patch implements this.
In issue
29c6c6fc8171287faa0079798ba2d6e3e7fd86f3
was noted that it would be nice to use value parsers for the timeouts in the CLI.
This patch implements this.
Thanks for the change!
This looks good, but I have two requests:
- Add a
heartwood/CHANEGLOG.mdentry. I would say it falls under a breaking change, unless9is still accepted as 9 seconds. Then maybe it’s considered a feature/improvement. - Can you confirm if the windows-sys changes are due to the dependency update or are they unrelated? If they’re unrelated could you remove them?
Added changelog.
Add a
heartwood/CHANEGLOG.mdentry. I would say it falls under a breaking change, unless9is still accepted as 9 seconds. Then maybe it’s considered a feature/improvement.
Done. I opted to move it to “breaking changes”, as it is clearly breaking a user interface ;-)
I can also move it to another section if you prefer!
Can you confirm if the windows-sys changes are due to the dependency update or are they unrelated? If they’re unrelated could you remove them?
Yeah, that change is most likely introduced via a transitive dependency of the newly introduced “humantime” dependency.
Changes:
- Rebase
- Drop windows-sys updates in Cargo.lock
- Fix
radicle-clitests
I believe this broke users that previously did e.g.
$ rad sync -f -t 3
which now errors with
error: invalid value '3' for '--timeout <TIMEOUT>': time unit needed, for example 3sec or 3ms
For more information, try '--help'.