Radish alpha
h
rad:z3gqcJUoA1n9HaHKufZs5FCSGazv5
Radicle Heartwood Protocol & Stack
Radicle
Git
Use humantime to parse timeouts
Merged did:key:z6MkoohH...AjJf opened 1 month ago

In issue

29c6c6fc8171287faa0079798ba2d6e3e7fd86f3

was noted that it would be nice to use value parsers for the timeouts in the CLI.

This patch implements this.

did:key:z6MkoohH...AjJf opened with revision 56350258 on base 9ff67562 +48 -31 1 month ago

In issue

29c6c6fc8171287faa0079798ba2d6e3e7fd86f3

was noted that it would be nice to use value parsers for the timeouts in the CLI.

This patch implements this.

fintohaps commented on revision 1 1 month ago

Thanks for the change!

This looks good, but I have two requests:

  • Add a heartwood/CHANEGLOG.md entry. I would say it falls under a breaking change, unless 9 is still accepted as 9 seconds. Then maybe it’s considered a feature/improvement.
  • Can you confirm if the windows-sys changes are due to the dependency update or are they unrelated? If they’re unrelated could you remove them?
did:key:z6MkrxqT...yQRh pushed revision 2 67641e9b on base 9ff67562 +51 -31 1 month ago

Added changelog.

did:key:z6MkrxqT...yQRh commented on revision 1 1 month ago

Add a heartwood/CHANEGLOG.md entry. I would say it falls under a breaking change, unless 9 is still accepted as 9 seconds. Then maybe it’s considered a feature/improvement.

Done. I opted to move it to “breaking changes”, as it is clearly breaking a user interface ;-)

I can also move it to another section if you prefer!

Can you confirm if the windows-sys changes are due to the dependency update or are they unrelated? If they’re unrelated could you remove them?

Yeah, that change is most likely introduced via a transitive dependency of the newly introduced “humantime” dependency.

fintohaps pushed revision 3 465489e1 on base 52e55812 +53 -33 1 month ago

Changes:

  • Rebase
  • Drop windows-sys updates in Cargo.lock
  • Fix radicle-cli tests
fintohaps merged revision 465489e1 at 99d92421 1 month ago
lorenz commented on revision 1 1 month ago

I believe this broke users that previously did e.g.

$ rad sync -f -t 3

which now errors with

error: invalid value '3' for '--timeout <TIMEOUT>': time unit needed, for example 3sec or 3ms

For more information, try '--help'.