Radish alpha
h
rad:z3gqcJUoA1n9HaHKufZs5FCSGazv5
Radicle Heartwood Protocol & Stack
Radicle
Git
node: Use winpipe for control socket on Windows
Merged lorenz opened 8 months ago

As std::os::unix is obviously not available on Windows, resort to the winpipe crate, which implements a very similar API for named pipes.

Apart from simple changes to imports, we need to jump through a few hoops because the std::io::{Read, Write} impls are on &mut for winpipe, thus yielding different mutability requirements on Unix vs. Windows.

We resort to cloning, but as this fallible, swallow the added complexity of a platform-dependent implementation to not risk panics on Unix.

lorenz opened with revision 5109cda9 on base a670b6e6 +71 -20 8 months ago

As std::os::unix is obviously not available on Windows, resort to the winpipe crate, which implements a very similar API for named pipes.

Apart from simple changes to imports, we need to jump through a few hoops because the std::io::{Read, Write} impls are on &mut for winpipe, thus yielding different mutability requirements on Unix vs. Windows.

We resort to cloning, but as this fallible, swallow the added complexity of a platform-dependent implementation to not risk panics on Unix.

lorenz pushed revision 2 f2060aa6 on base a670b6e6 +75 -20 8 months ago

Review

fintohaps pushed revision 3 6e77ad97 on base ce11f03f +75 -20 8 months ago

Rebased

fintohaps pushed revision 4 27cef672 on base ce11f03f +74 -20 8 months ago

Changes:

  • Missed cargo fmt
fintohaps merged revision 27cef672 at 19a262d3 8 months ago