In many cases the radicle node is already aware of the publicly advertised addresses for each node. This PR attempts to offer connection by nid alone, ommiting the @addr part.
rad node connect z6MkrLMMsiPWUcNPHcRajuMi9mDfYckSoJyPwwnknocNYPm7 now works by finding an advertised public url to attempt the connection with. Tor and local addresses are not in scope.
In many cases the radicle node is already aware of the publicly advertised addresses for each node. This PR attempts to offer connection by nid alone, ommiting the @addr part.
rad node connect z6MkrLMMsiPWUcNPHcRajuMi9mDfYckSoJyPwwnknocNYPm7 now works by finding an advertised public url to attempt the connection with. Tor and local addresses are not in scope.
remove todo comment
Add example tests for rad node connect
See commit for reviewed changes
Changes:
- Clean up commits
- Attempt to connect to all addresses, where it stops at the first success, via
new function
connect_many - Adds a new test
rad_node_connect_without_address