Radish alpha
h
rad:z3gqcJUoA1n9HaHKufZs5FCSGazv5
Radicle Heartwood Protocol & Stack
Radicle
Git
Implement COB caching
Merged fintohaps opened 2 years ago

This patch implements caching for COBs by using an SQLite database that is used as a write-thru cache. All reads are replaced with using the cache so as to avoid recomputing the COB graph each time.

fintohaps opened with revision 49acb9af on base 9767b485 +2638 -284 2 years ago

This patch implements caching for COBs by using an SQLite database that is used as a write-thru cache. All reads are replaced with using the cache so as to avoid recomputing the COB graph each time.

fintohaps pushed revision 2 49c116e7 on base 9767b485 +2785 -285 2 years ago

Changes:

  • added cache subcommands for patch and issue
did:key:z6MksFqX...wzpT reviewed 2 years ago
fintohaps pushed revision 3 703dd16d on base 9767b485 +3169 -294 2 years ago

Changes:

  • Document modules and new additions
  • Order by is listing queries
  • Add listing by different statuses for patches (includes adding new Status type)
  • recache split into two functions, write and write_all
  • reader db’s no longer migrate
  • formatted sql schemas
  • Remove::remove no longer required the RID
  • Clean up of PatchMut
  • cache/cobs.db renamed to cobs/cache.db
  • Remove Cacheable type and inline usage of its methods
  • Simplify Cache types to take any R, not necessarily the underlying stores. This allows for more flexible caching and definitions, e.g. when paired with anything that implements HasRid (a newly introduced trait), we get all of the Patches and Issues methods. This could potentially mean we could unify the two different Cache types in a future change.

N.B. all new commits are fixups to help with revision-to-revision review and will be squashed once it’s ready for merging.

fintohaps pushed revision 4 7e7033ac on base 9767b485 +3167 -315 2 years ago

Changes:

  • Removed Filter type in patch command
  • Fixed COB type name in update error
  • Squashed fixup commits
did:key:z6MksFqX...wzpT pushed revision 5 098a3c9e on base 17744a03 +3162 -310 2 years ago

Rebase.

did:key:z6MksFqX...wzpT pushed revision 6 7c10a924 on base 9767b485 +3166 -315 2 years ago

Fix broken build due to bad import.

did:key:z6MksFqX...wzpT pushed revision 7 baf10014 on base 9e745b68 +0 -0 2 years ago

Reset to master.

did:key:z6MksFqX...wzpT merged revision baf10014 at 9e745b68 2 years ago
lorenz commented on revision 1 1 year ago

@fintohaps I did not look into the actual changes yet, before I do that I would like get clarification from you that this patch is indeed still relevant. It’s been a while… Thanks!