Radish alpha
h
rad:z3gqcJUoA1n9HaHKufZs5FCSGazv5
Radicle Heartwood Protocol & Stack
Radicle
Git
radicle: fix diverging quorum
Merged fintohaps opened 1 year ago

When calculating a quorum there was a case where two heads that were equal would result in double-counting, allowing the quorum to pass a threshold higher than the expected votes.

To prevent this, each head is immediately counted as a direct vote. Then, when comparing the head to the rest of the set, if they are equal that iteration would be skipped. This is because the merge base of two equal commits is that commit, resulting in the double-counting.

Note that the skip can also skip the current head, so i + 1 is used.

fintohaps opened with revision 4659525c on base a6e33ec1 +22 -3 1 year ago

When calculating a quorum there was a case where two heads that were equal would result in double-counting, allowing the quorum to pass a threshold higher than the expected votes.

To prevent this, each head is immediately counted as a direct vote. Then, when comparing the head to the rest of the set, if they are equal that iteration would be skipped. This is because the merge base of two equal commits is that commit, resulting in the double-counting.

Note that the skip can also skip the current head, so i + 1 is used.

did:key:z6MksFqX...wzpT pushed revision 2 f91a0c3e on base 589c3756 +31 -3 1 year ago

Rebase, add a few tests.

did:key:z6MksFqX...wzpT merged revision f91a0c3e at 3260046c 1 year ago