Radish alpha
h
rad:z3gqcJUoA1n9HaHKufZs5FCSGazv5
Radicle Heartwood Protocol & Stack
Radicle
Git
httpd: improve error message for missing browser
Merged fintohaps opened 2 years ago

If open or xdg-open fail the error is:

No such file or directory (os error 2)

This generally means that the command could not open the browser on the OS. To provide better help, improve the error message by informing the user what went wrong and that they can run rad web --no-open instead.

Signed-off-by: Fintan Halpenny fintan.halpenny@gmail.com X-Clacks-Overhead: GNU Terry Pratchett

fintohaps opened with revision 383530ec on base 9767b485 +6 -1 2 years ago

If open or xdg-open fail the error is:

No such file or directory (os error 2)

This generally means that the command could not open the browser on the OS. To provide better help, improve the error message by informing the user what went wrong and that they can run rad web --no-open instead.

Signed-off-by: Fintan Halpenny fintan.halpenny@gmail.com X-Clacks-Overhead: GNU Terry Pratchett

did:key:z6MkkfM3...sVz5 accepted 2 years ago

Nice! Much better then currently

did:key:z6Mkgfwr...BYQp commented on revision 1 2 years ago

Why not falling back directly to printing the URL? I mean, do keep the error message but still print the URL, such that rad web need not be run again. Wouldn’t that improve the user experience?

fintohaps pushed revision 2 4ea7a67e on base 9767b485 +13 -7 2 years ago

Changes:

  • Still print the URL to visit
did:key:z6MksFqX...wzpT pushed revision 3 92c392c2 on base ccec3f80 +13 -7 2 years ago

Rebase.

did:key:z6MksFqX...wzpT merged revision 92c392c2 at b6e1385e 2 years ago