Radish alpha
h
Radicle Heartwood Protocol & Stack
Radicle
Git (anonymous pull)
Log in to clone via SSH
Add --author and --authored flags to "rad issue (list)"
◌ 0/1 checks passed did:key:z6MkrxqT...yQRh wants to merge 1 commit into master · opened 2 months ago

This patch adds filtering functionality for the author of an issue when listing issues.

In large repositories like heartwood, rad issue list lists more than one screen size of issues. For boiling down this list (for example to find issue IDs of issues oneself has authored), this patch introduces the --authored and --author arguments that are already known from rad patch list.

This makes the interface of that subcommand symmetric to rad patch list, which is desireable from a UX standpoint as well.

Checks in progress — 0 passed, 1 pending View logs ↗
did:key:z6MkrxqT...yQRh opened with revision 0a3e348517453d4cfd80144125c8f5241eba7aec on base e9245b630d728672d2b3d6ff9265fa4f1a86f13a +45 -0 2 months ago
did:key:z6MkireR...3voM pushed revision 2 db46f830236ee0b47a6e53282b20f9dc412885e7 on base e9245b630d728672d2b3d6ff9265fa4f1a86f13a +56 -9 2 months ago

REVIEW: share AuthorArgs

Shares the newly introduced fields in an AuthorArgs struct, and uses flatten to get back the original arg behaviour.

Move the resolution logic of the BTreeSet<Did> into AuthorArgs::authors, and surface through ListArgs::authors. This requires some reorganisation to satisfy the borrow checker.

did:key:z6MkireR...3voM commented on revision 1 2 months ago

I've added a revision with a REVIEW commit (see revision db46f83)

This would be my preferred way of wiring this up, but open for discussion.

I would also like some tests added in radicle-cli/examples – either to the existing rad issue example(s) or a new one.

Please add a CHANGELOG entry as well.