Radish alpha
h
Radicle Heartwood Protocol & Stack
Radicle
Git (anonymous pull)
Log in to clone via SSH
`rad patch review` doesn't work, should be dropped or hidden?
liw opened 9 months ago

From https://radicle.zulipchat.com/#narrow/channel/369873-support/topic/new.20to.20reviewing.20patches/near/532848924, by Fintan:

Sorry about this, the review subcommand doesn't really work. It was a PoC that never got removed properly. However, you can review code with radicle-desktop

We should probably remove, or at least hide, stuff that doesn't work, unless we're going to fix it. Until we fix it, maybe a warning in the help text/manual page?

z6MkwcUR...q1kL commented 9 months ago

[...] the review subcommand doesn't really work

We should probably remove, or at least hide, stuff that doesn't work

That would also mean that we should remove the "resolve" command, right?

z6MkgFq6...nBGz added type=bug 8 months ago
z6MkgFq6...nBGz added crate=radicle-cli 8 months ago
dsommers commented 3 months ago

Is this related to the radicle-cli had a problem and crashed. message I get when I run rad patch review on a specific patch?

I'm new to radicle and testing it out on a private repo setup, so if this isn't intended to work - then I can just ignore this command

As a newbie, the command lines gets really confusing when there are non-functional operations. So that would then be a vote to at least hide the review operation.

z6MkgEMYod7Hxfy9qCvDv5hYHkZ4ciWmLFgfvm3Wn1b2w2FV wrote:

From https://radicle.zulipchat.com/#narrow/channel/369873-support/topic/new.20to.20reviewing.20patches/near/532848924, by Fintan:

Sorry about this, the review subcommand doesn't really work. It was a PoC that never got removed properly. However, you can review code with radicle-desktop

We should probably remove, or at least hide, stuff that doesn't work, unless we're going to fix it. Until we fix it, maybe a warning in the help text/manual page?

z6MkwcURkqsfxaqUvxME953L1CDRae1KDyPxvr7zsRDWq1kL wrote:

[...] the review subcommand doesn't really work

We should probably remove, or at least hide, stuff that doesn't work

That would also mean that we should remove the "resolve" command, right?