Radish alpha
h
rad:z3gqcJUoA1n9HaHKufZs5FCSGazv5
Radicle Heartwood Protocol & Stack
Radicle
Git
radicle: existing COB improvements
Open fintohaps opened 1 year ago crate=radicle type=improvements

After chatting with the desktop team, there are some areas for improvement in the Patch and Issue COBs.

Patch

  • Edit history for titles. I think this could be a new type, wrapping around NonEmpty, and it should be a backwards compatible change.
  • We will meet about code range comments to discuss the already open patch.

Review

  • They proposed to deprecate the labels in a Review because they do not make much sense there. I’d agree, but I’m also fine with leaving them there for backwards compatability.
  • Add edit history and embeds to the review summary – this should be straight-forward by using the Edit struct with NonEmpty, and I believe it should be a backwards-compatible change
  • Reactions for reviews – these would need to be added to the struct and an action added to accept them. Note that the CLI should be updated to be able to react to a review as well.

Issue

  • Edit history for titles, similar to Patch

Note that even though changes will be backwards-compatible, there will be migrations required for the cache. This might mean that it would be better to do all of these in one go, except for code range comments – my patch does it in such a way that it is backwards compatible. Adding reactions to reviews should also be easy, since we can use serde to default to empty vecs and not to serialize if no reactions are present.