Radish alpha
h
heartwood
rad:z3gqcJUoA1n9HaHKufZs5FCSGazv5
Radicle Heartwood Protocol & Stack
Radicle
Git
Issues › 0e50d7a1
`rad issue edit` didn't automatically announce
Open did:key:z6Mko5mi...bgMH opened 1 year ago

I did rad issue edit, twice, on an issue I opened, then waited approx. 15 minutes to see the changes reflected by both rad issue show in a different node of mine and in the web explorer, but the changes didn’t appear.

Then I did rad sync -v in the repo and that didn’t say “Nothing to announce”, implying there was something to announce. After that, my edits to my issue appeared in both my different node and in the web explorer.

Not sure if this behavior of rad issue edit is intended, but with other rad commands, including rad issue open, doing automatic announcing, I was confused about where my edits went (though, I could see them locally). When I was editing my issue, I assumed it would automatically announce when I finished.

If the current no-announcing behavior is intended to be kept, I suggest that rad issue edit say (print when CLI) a message when it’s finished about what the user will need to do to make the edit appear to the network.

z6Mko5mi...bgMH commented 1 year ago

The same behavior, of not automatically announcing, also occurs with rad issue comment.

fintohaps commented 1 year ago

Hey Derick,

Thanks for pointing this out! This is just a case of missing some matches in this code:

    let announce = options.announce
        && matches!(
            &options.op,
            Operation::Open { .. }
                | Operation::React { .. }
                | Operation::State { .. }
                | Operation::Delete { .. }
                | Operation::Assign { .. }
                | Operation::Label { .. }
        );

I can create a patch to amend the issue.

Sign in with GitHub to comment