eea3617 use `CONIN$` instead of `/dev/tty` on windows — heartwood

rad:z3gqcJUoA1n9HaHKufZs5FCSGazv5

Radicle Heartwood Protocol & Stack

use `CONIN$` instead of `/dev/tty` on windows

justarandomgeek committed 1 month ago

commit eea3617781d50dc9f908e98f10c39a9ed125d08f
parent a1fd9e0

2 files changed +5 -0

modified CHANGELOG.md

@@ -46,6 +46,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

   indistinguishable from `[::1]:8776`. Since a port number is always required
   along a host when providing an address, IPv6 addresses now always require
   brackets to avoid confusion.
 - On Windows, use `CONIN$` to reopen the terminal input stream, instead of refusing
   to launch an editor for `radicle-remote-helper`
 ## Deprecations

modified crates/radicle-term/src/editor.rs

@@ -162,6 +162,9 @@ impl Editor {

                 .write(true)
                 .open("/dev/tty")?;
             process::Stdio::from(tty)
         } else if cfg!(windows) {
             let tty = fs::OpenOptions::new().read(true).open("CONIN$")?;
             process::Stdio::from(tty)
         } else {
             return Err(io::Error::new(
                 io::ErrorKind::Unsupported,